Bug 1798278

Summary: subscription-manager recommends drags in too much into RHCOS
Product: Red Hat Enterprise Linux 8 Reporter: Colin Walters <walters>
Component: skopeoAssignee: Jindrich Novy <jnovy>
Status: CLOSED ERRATA QA Contact: Yuhui Jiang <yujiang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: bbreard, dwalsh, imcleod, jnovy, lsm5, miabbott, tsweeney, ypu
Target Milestone: rcKeywords: Reopened, Triaged
Target Release: 8.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: skopeo-1.2.1-7.el8 or newer Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:32:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Colin Walters 2020-02-05 02:41:59 UTC
Please remove Recommends: subscription-manager from container-common (which is a dependency of podman/skopeo etc.)

This came from https://src.osci.redhat.com/rpms/skopeo/c/9ad6add6ee6602fa82d4bb85d899301ca14d6774

Yes, at some point in the future we will probably switch off Recommends in RHCOS.

But let's not do this now please since RHCOS doesn't want to drag all of that in, and we're not quite ready to investigate disabling recommends.

Comment 1 Colin Walters 2020-02-05 02:44:06 UTC
https://issues.redhat.com/browse/GRPA-591

Comment 2 Tom Sweeney 2020-02-05 18:10:28 UTC
Jindrich I think you can take care of this, please holler if not.  I've also cc'd Lokesh in case this is in his purview instead.

Comment 3 Colin Walters 2020-02-06 17:22:03 UTC
FWIW we have a workaround now; so urgency is lower.

I still don't think this `Recommends:` was right, but not going to fight hard to drop it either.

Comment 4 Jindrich Novy 2020-02-07 11:15:45 UTC
If the concern is to have a minimal installation footprint then it makes sense to disable Recommends/Suggests/Enhances. It would be more of an issue if it Requires the dependency as it couldn't be avoided.

The subscription management functionality is still required for some use cases so removing the Recommends as a whole wouldn't be a good thing to do.

Comment 7 Ben Breard 2020-08-20 23:42:22 UTC
reopening this BZ as we're running into the same problem with the rpm-ostree builds from Image Builder. Jindrich, can we drop subscription-manager from recommends? It creates the problem of pulling in other deps like DNF that are problematic for us.

Comment 8 Jindrich Novy 2020-08-21 05:59:26 UTC
At this point I'd suggest to create a new skopeo-subscription-manager subpackage where the relevant symlinks and the subscription-manager dependency (this time a hard dep) would be specified. By default installation of skopeo there won't be any (even soft) subscription-manager dependency. Sounds good Ben, Dan, Colin?

Comment 9 Tom Sweeney 2020-08-21 15:32:19 UTC
I'll add Ian McLeod to the ping list too, in case he's some thoughts/concerns here.

Comment 10 Tom Sweeney 2020-08-21 15:34:23 UTC
And as a reminder, Colin did opoen up a Jira card: https://issues.redhat.com/browse/GRPA-591 to handle this RFE.

Comment 11 Daniel Walsh 2020-08-24 10:27:49 UTC
Container images need this requirement, not the Base OS.  I don't understand why this was added to these packages in the first place.

All of the container-tools will work fine without subscription manager?

Comment 13 Daniel Walsh 2021-01-28 12:08:28 UTC
Jindrich did you remove the recommends?

Comment 14 Jindrich Novy 2021-01-28 12:25:39 UTC
The subscription-manager is added as a soft dependency so that skopeo doesn't ship dangling symlinks. Given it's a soft dep the subscription-manager package is optional. https://issues.redhat.com/browse/GRPA-591 should address this for RHCOS by not installing soft deps.

If I remove subscription-manager I'd introduce a regression a a customer in previous releases requested it as a softdep for the reasons above.

Comment 15 Daniel Walsh 2021-01-28 22:54:45 UTC
What if we changed it to a suggests?

Comment 16 Jindrich Novy 2021-01-29 08:54:07 UTC
Suggests would work as it's a hint (not weak/soft dep as Recommends) meaning hint deps are ignored by DNF.

https://fedoraproject.org/wiki/Packaging:WeakDependencies#Introduction
https://fedoraproject.org/wiki/Packaging:WeakDependencies#Hints

Comment 24 errata-xmlrpc 2021-05-18 15:32:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: container-tools:rhel8 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1796