Bug 1798706
| Summary: | need a more graceful way to fail when attempting to writecache an origin using a RO pool device | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | LVM and device-mapper development team <lvm-team> |
| lvm2 sub component: | Cache Logical Volumes | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | low | ||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, mcsontos, msnitzer, pasik, prajnoha, teigland, zkabelac |
| Version: | 8.2 | Flags: | pm-rhel:
mirror+
|
| Target Milestone: | rc | ||
| Target Release: | 8.0 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.03.08-2.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-28 16:59:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Corey Marthaler
2020-02-05 20:03:54 UTC
The problem is that wipe_lv() does not return an error when writes to the LV fail, leaving the LV uninitialized. Since wipe_lv has always ignored errors and is widely used elsewhere, we need to check what other effects might come from fixing it. pushed a limited fix to master (just checks if the cachevol is writable, but doesn't check for failed wiping more generally): https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=cba06012acc589888ef88221f1a580b5b81b4100 Fix verified in the latest rpms. kernel-4.18.0-179.el8 BUILT: Fri Feb 14 17:03:01 CST 2020 lvm2-2.03.08-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 lvm2-libs-2.03.08-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-libs-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-event-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-event-libs-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 [root@hayes-02 ~]# lvcreate --wipesignatures y -L 4G -n cworigin writecache_sanity @slow Logical volume "cworigin" created. [root@hayes-02 ~]# lvcreate -p r -L 1G -n ro_pool writecache_sanity /dev/sdm1 WARNING: Logical volume writecache_sanity/ro_pool not zeroed. Logical volume "ro_pool" created. [root@hayes-02 ~]# lvchange -an writecache_sanity [root@hayes-02 ~]# lvconvert --yes --type writecache --cachevol writecache_sanity/ro_pool writecache_sanity/cworigin Cannot initialize readonly LV writecache_sanity/ro_pool LV writecache_sanity/ro_pool could not be zeroed. [root@hayes-02 ~]# echo $? 5 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:1881 |