Bug 1798798

Summary:	Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Ankur Sinha (FranciscoD) <sanjay.ankur>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dan.cermak, package-review, sanjay.ankur
Target Milestone:	---	Flags:	sanjay.ankur: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-27 08:01:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1798796, 1798797
Bug Blocks:	1801421

Description Jerry James 2020-02-06 03:08:52 UTC

Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving.spec
SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving-4.4-1.fc32.src.rpm
RPMLINTRC URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving.rpmlintrc
Fedora Account System Username: jjames
Description: Deriving is a library simplifying type-driven code generation on OCaml.  It includes a set of useful plugins: show, eq, ord (eq), enum, iter, map (iter), fold (iter), make, yojson, and protobuf.

Comment 1 Ankur Sinha (FranciscoD) 2020-02-12 16:48:35 UTC

I can review this one too since no one has taken it up yet.

Comment 2 Jerry James 2020-02-13 03:38:20 UTC

Thank you, Ankur!  I had to make some changes due to a recent ocaml-ounit update, so I just pushed fixed spec and srpm files to the URLs above.  Let me know if you need anything reviewed.

Comment 3 Ankur Sinha (FranciscoD) 2020-02-20 14:41:38 UTC

Hi Jerry,

Just managed to run it through FedoraReview now. The build seems to be failing in the check section. Could you please take a look?

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.ffMslv
+ umask 022
+ cd /builddir/build/BUILD
+ cd ppx_deriving-4.4
+ dune runtest
File "src_test/deriving/test_ppx_deriving.ml", line 4, characters 25-35:
4 |   let sort = List.sort [%derive.ord: int * int] in
                             ^^^^^^^^^^
Error: Uninterpreted extension 'derive.ord'.
File "src_test/create/test_deriving_create.ml", line 38, characters 24-32:
38 |   assert_equal ~printer:M.show_a
                             ^^^^^^^^
Error: Unbound value M.show_a
File "test_deriving_eq.cppo.ml", line 24, characters 31-39:
Error: Unbound value equal_a1
File "test_deriving_fold.cppo.ml", line 8, characters 41-51:
Error: Unbound value fold_btree
File "test_deriving_iter.cppo.ml", line 34, characters 2-12:
Error: Unbound value iter_btree
File "src_test/enum/test_deriving_enum.ml", line 7, characters 42-52:
7 |   assert_equal ~printer:string_of_int 0  (va_to_enum Aa);
                                              ^^^^^^^^^^
Error: Unbound value va_to_enum
File "src_test/make/test_deriving_make.ml", line 48, characters 24-32:
48 |   assert_equal ~printer:M.show_a
                             ^^^^^^^^
Error: Unbound value M.show_a
File "test_deriving_map.cppo.ml", line 81, characters 15-24:
Error: Unbound value map_btree
File "test_deriving_ord.cppo.ml", line 22, characters 30-40:
Error: Unbound value compare_a1
Hint: Did you mean compare?
File "test_deriving_show.cppo.ml", line 23, characters 35-42:
Error: Unbound value show_a1
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.ffMslv (%check)
    Bad exit status from /var/tmp/rpm-tmp.ffMslv (%check)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace


Cheers,

Comment 4 Jerry James 2020-02-21 23:28:54 UTC

Yes, I see that, too.  I swear that didn't happen when I built it to submit for review. :-)  I don't know offhand what is going wrong, but I'll look into it.  Thanks!

Comment 5 Ankur Sinha (FranciscoD) 2020-02-28 08:47:22 UTC

No worries, please let me know when it's ready for another look :)

Comment 6 Jerry James 2020-03-10 23:51:09 UTC

A problem with the ocaml-ppxfind package that caused the test failures has been fixed in Rawhide.  Due to beta freeze, it has not yet been fixed for F32, but will be.

New URLs:
Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving.spec
SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving-4.4.1-1.fc33.src.rpm

Comment 7 Jerry James 2020-03-17 17:50:40 UTC

The ocaml-ppxfind package has now been built for F32.  Let me know if you want a buildroot override.  Building for Rawhide has been okay for a week, so no problem there.

Comment 8 Jerry James 2020-03-18 22:19:20 UTC

Ankur, are you available to continue this review?

Comment 9 Ankur Sinha (FranciscoD) 2020-03-18 22:39:40 UTC

Yes, sorry, just running it through fedora-review now.

Comment 10 Ankur Sinha (FranciscoD) 2020-03-18 23:09:36 UTC

Looks good. XXX APPROVED XXX

Please do check the Requires and Provides once. They look OK, but I don't know
enough about the other OCaml packages to check them for correctness.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
^
Look OK, but please do take a look to confirm.

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ocaml:
[x]: This should never happen
^
I don't know what this is about, perhaps a fedora-review bug..

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
^
Look OK but please check once to confirm.

[!]: Package functions as described.
^
Not tested, leaving this up to you :)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ocaml-ppx-deriving-4.4.1-1.fc33.x86_64.rpm
          ocaml-ppx-deriving-devel-4.4.1-1.fc33.x86_64.rpm
          ocaml-ppx-deriving-doc-4.4.1-1.fc33.noarch.rpm
          ocaml-ppx-deriving-debuginfo-4.4.1-1.fc33.x86_64.rpm
          ocaml-ppx-deriving-debugsource-4.4.1-1.fc33.x86_64.rpm
          ocaml-ppx-deriving-4.4.1-1.fc33.src.rpm
ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US yojson -> yonks
ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US protobuf -> prototype
ocaml-ppx-deriving-devel.x86_64: W: no-documentation
ocaml-ppx-deriving.src: W: spelling-error %description -l en_US eq -> e, q, seq
ocaml-ppx-deriving.src: W: spelling-error %description -l en_US ord -> rod, or, rd
ocaml-ppx-deriving.src: W: spelling-error %description -l en_US enum -> menu, en um, en-um
ocaml-ppx-deriving.src: W: spelling-error %description -l en_US iter -> tier, tire, inter
ocaml-ppx-deriving.src: W: spelling-error %description -l en_US yojson -> yonks
ocaml-ppx-deriving.src: W: spelling-error %description -l en_US protobuf -> prototype
6 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (debuginfo)
-------------------
Checking: ocaml-ppx-deriving-debuginfo-4.4.1-1.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_GB.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_GB.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
ocaml-ppx-deriving-doc.noarch: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known>
ocaml-ppx-deriving-debugsource.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known>
ocaml-ppx-deriving-devel.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known>
ocaml-ppx-deriving-devel.x86_64: W: no-documentation
ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US yojson -> yonks
ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US protobuf -> prototype
ocaml-ppx-deriving.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known>
ocaml-ppx-deriving-debuginfo.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known>
5 packages and 0 specfiles checked; 0 errors, 8 warnings.



Source checksums
----------------
https://github.com/ocaml-ppx/ppx_deriving/archive/v4.4.1/ppx_deriving-4.4.1.tar.gz :
  CHECKSUM(SHA256) this package     : 27bc57774724fc4f48775f2011375a5ee1439570204abbf6607761c472757e2f
  CHECKSUM(SHA256) upstream package : 27bc57774724fc4f48775f2011375a5ee1439570204abbf6607761c472757e2f


Requires
--------
ocaml-ppx-deriving (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libm.so.6()(64bit)
    ocaml(Ast_convenience)
    ocaml(Ast_helper)
    ocaml(Ast_mapper)
    ocaml(Build_path_prefix_map)
    ocaml(CamlinternalFormatBasics)
    ocaml(CamlinternalLazy)
    ocaml(Clflags)
    ocaml(Config)
    ocaml(Docstrings)
    ocaml(Load_path)
    ocaml(Location)
    ocaml(Longident)
    ocaml(Migrate_parsetree)
    ocaml(Migrate_parsetree__)
    ocaml(Migrate_parsetree__Ast_402)
    ocaml(Migrate_parsetree__Ast_403)
    ocaml(Migrate_parsetree__Ast_404)
    ocaml(Migrate_parsetree__Ast_405)
    ocaml(Migrate_parsetree__Ast_406)
    ocaml(Migrate_parsetree__Ast_407)
    ocaml(Migrate_parsetree__Ast_408)
    ocaml(Migrate_parsetree__Ast_408_helper)
    ocaml(Migrate_parsetree__Ast_409)
    ocaml(Migrate_parsetree__Ast_409_helper)
    ocaml(Migrate_parsetree__Ast_410)
    ocaml(Migrate_parsetree__Locations)
    ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions)
    ocaml(Migrate_parsetree__Migrate_parsetree_driver)
    ocaml(Migrate_parsetree__Migrate_parsetree_versions)
    ocaml(Migrate_parsetree__Stdlib0)
    ocaml(Misc)
    ocaml(Pprintast)
    ocaml(Ppx_derivers)
    ocaml(Ppx_deriving)
    ocaml(Profile)
    ocaml(Result)
    ocaml(Stdlib)
    ocaml(Stdlib__arg)
    ocaml(Stdlib__array)
    ocaml(Stdlib__buffer)
    ocaml(Stdlib__char)
    ocaml(Stdlib__digest)
    ocaml(Stdlib__filename)
    ocaml(Stdlib__format)
    ocaml(Stdlib__hashtbl)
    ocaml(Stdlib__int32)
    ocaml(Stdlib__int64)
    ocaml(Stdlib__lazy)
    ocaml(Stdlib__lexing)
    ocaml(Stdlib__list)
    ocaml(Stdlib__map)
    ocaml(Stdlib__nativeint)
    ocaml(Stdlib__obj)
    ocaml(Stdlib__option)
    ocaml(Stdlib__parsing)
    ocaml(Stdlib__pervasives)
    ocaml(Stdlib__printexc)
    ocaml(Stdlib__printf)
    ocaml(Stdlib__queue)
    ocaml(Stdlib__result)
    ocaml(Stdlib__seq)
    ocaml(Stdlib__set)
    ocaml(Stdlib__string)
    ocaml(Stdlib__sys)
    ocaml(Stdlib__uchar)
    ocaml(Syntaxerr)
    ocaml(Type_immediacy)
    ocaml(Warnings)
    ocaml(runtime)
    rtld(GNU_HASH)

ocaml-ppx-deriving-devel (rpmlib, GLIBC filtered):
    ocaml-migrate-parsetree-devel(x86-64)
    ocaml-ppx-derivers-devel(x86-64)
    ocaml-ppx-deriving(x86-64)
    ocaml-ppx-tools-devel(x86-64)
    ocaml-result-devel(x86-64)

ocaml-ppx-deriving-doc (rpmlib, GLIBC filtered):

ocaml-ppx-deriving-debuginfo (rpmlib, GLIBC filtered):

ocaml-ppx-deriving-debugsource (rpmlib, GLIBC filtered):



Provides
--------
ocaml-ppx-deriving:
    ocaml(Ppx_deriving)
    ocaml(Ppx_deriving_create)
    ocaml(Ppx_deriving_enum)
    ocaml(Ppx_deriving_eq)
    ocaml(Ppx_deriving_fold)
    ocaml(Ppx_deriving_iter)
    ocaml(Ppx_deriving_make)
    ocaml(Ppx_deriving_map)
    ocaml(Ppx_deriving_ord)
    ocaml(Ppx_deriving_runtime)
    ocaml(Ppx_deriving_show)
    ocaml(Ppx_deriving_std)
    ocaml-ppx-deriving
    ocaml-ppx-deriving(x86-64)

ocaml-ppx-deriving-devel:
    ocaml-ppx-deriving-devel
    ocaml-ppx-deriving-devel(x86-64)

ocaml-ppx-deriving-doc:
    ocaml-ppx-deriving-doc

ocaml-ppx-deriving-debuginfo:
    debuginfo(build-id)
    ocaml-ppx-deriving-debuginfo
    ocaml-ppx-deriving-debuginfo(x86-64)

ocaml-ppx-deriving-debugsource:
    ocaml-ppx-deriving-debugsource
    ocaml-ppx-deriving-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1798798
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic, Ocaml
Disabled plugins: Perl, PHP, Python, fonts, Haskell, Java, SugarActivity, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 11 Jerry James 2020-03-19 17:08:22 UTC

Thank you, Ankur!  I appreciate the review.  The Requires and Provides look fine to me.

Comment 12 Gwyn Ciesla 2020-03-19 18:20:13 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-deriving

Comment 13 Fedora Update System 2020-03-19 20:27:22 UTC

FEDORA-2020-d1320503c7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d1320503c7

Comment 14 Fedora Update System 2020-03-20 01:59:16 UTC

ocaml-ppx-deriving-4.4.1-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d1320503c7

Comment 15 Fedora Update System 2020-03-27 08:01:39 UTC

FEDORA-2020-d1320503c7 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.