Bug 1799011

Summary: incremental-backup: RFE: Handle backup bitmaps during live migration with shared storage
Product: Red Hat Enterprise Linux Advanced Virtualization Reporter: Peter Krempa <pkrempa>
Component: libvirtAssignee: Peter Krempa <pkrempa>
Status: CLOSED CURRENTRELEASE QA Contact: yisun
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.2CC: eshenitz, lmen, ngu, nsoffer, virt-maint, xuzhang
Target Milestone: rcKeywords: TestOnly, Triaged
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-01-08 16:30:51 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1207659, 1858739    
Bug Blocks: 1139877, 1799015, 1861680    

Description Peter Krempa 2020-02-06 13:21:01 UTC
Description of problem:
Libvirt currently doesn't handle bitmaps used to drive the incremental backup feature during live migration. Incremental backup would not be possible after a migration without migrating the active bitmaps.

Comment 1 Nir Soffer 2020-02-11 15:18:39 UTC
Until this is fixed, RHV need to either:
- disable live migration functionality if incremental backup is enabled
- delete all checkpoints before live migration, forcing the next backup to be a full backup

Comment 2 Eyal Shenitzky 2020-07-29 08:38:58 UTC
Peter, according to what you said on our meetings this issue should be fixed right?

Comment 3 Peter Krempa 2020-07-29 09:04:48 UTC
Success code paths of migrations should work at this point. There's a qemu bug which might prevent resuming the source if migration fails in certain phases (unlikely): https://bugzilla.redhat.com/show_bug.cgi?id=1858739

In this bug I want to test it and potentially implement code to transport bitmaps over the migration stream which is supposed to be more efficient.

Comment 4 Eyal Shenitzky 2020-08-03 10:16:57 UTC
(In reply to Peter Krempa from comment #3)
> Success code paths of migrations should work at this point. There's a qemu
> bug which might prevent resuming the source if migration fails in certain
> phases (unlikely): https://bugzilla.redhat.com/show_bug.cgi?id=1858739
> 
> In this bug I want to test it and potentially implement code to transport
> bitmaps over the migration stream which is supposed to be more efficient.

Peter, can you please clarify what exactly should work?

Does a VM that contains checkpoints and bitmaps should migrate successfully?
New incremental backup can be taken after the VM was live migrated?

Comment 5 Peter Krempa 2020-08-03 10:26:22 UTC
(In reply to Eyal Shenitzky from comment #4)
> (In reply to Peter Krempa from comment #3)
> > Success code paths of migrations should work at this point. There's a qemu
> > bug which might prevent resuming the source if migration fails in certain
> > phases (unlikely): https://bugzilla.redhat.com/show_bug.cgi?id=1858739
> > 
> > In this bug I want to test it and potentially implement code to transport
> > bitmaps over the migration stream which is supposed to be more efficient.
> 
> Peter, can you please clarify what exactly should work?
> 
> Does a VM that contains checkpoints and bitmaps should migrate successfully?
> New incremental backup can be taken after the VM was live migrated?

Yes, both cases should work. Note that the checkpoint definitions are not migrated at this point, so need to be redefined, but since oVirt is already doing that when starting the VM this should not be a problem.

Comment 6 Peter Krempa 2020-08-07 14:06:25 UTC
I've filed multiple bugs dealing with specifics sub-issues of this. I'm also re-purposing this bug to specifically track migration of bitmaps when shared storage migration is used.

 - https://bugzilla.redhat.com/show_bug.cgi?id=1867086
   incremental backup: RFE: migrate bitmaps over qemu's migration stream also for shared-storage migration

 - https://bugzilla.redhat.com/show_bug.cgi?id=1867085
   incremental backup: RFE: Migrate bitmaps when migrating VM with --copy-storage-all

 - https://bugzilla.redhat.com/show_bug.cgi?id=1867084
  incremental backup: RFE: Add mechanism to migrate checkpoint definitions with VM

Since the bitmaps are for now migrated by qemu and every other problem is tracked. I'll set this bug as test-only.

Comment 7 yisun 2020-09-14 02:59:07 UTC
Per comment6, will remove "NewFeature" tag since it's a TESTONLY issue now. And storage migration part will be tracked in separated RFEs

Comment 10 Jeff Nelson 2021-01-08 16:30:51 UTC
RHEL AV 8.3.0 has been shipped, therefore marking this BZ CLOSED CURRENTRELEASE.