Bug 1800370

Summary: python-json5 fails to build with Python 3.9: Extra , in test_skip_keys
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-json5Assignee: Fabian Affolter <mail>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, mail, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-19 12:59:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-02-07 00:54:55 UTC
python-json5 fails to build with Python 3.9.0a3.

======================================================================
FAIL: test_skip_keys (tests.lib_test.TestDumps)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pyjson5-0.9.0/tests/lib_test.py", line 378, in test_skip_keys
    self.assertEqual(json5.dumps({"foo": 1, (1, 2): 2}, skipkeys=True),
AssertionError: '{foo: 1, }' != '{foo: 1}'
- {foo: 1, }
?        --
+ {foo: 1}
----------------------------------------------------------------------
Ran 61 tests in 0.074s
FAILED (failures=1)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01223750-python-json5/

For all our attempts to build python-json5 with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-json5/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2020-02-11 16:39:24 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 2 Fabian Affolter 2020-03-19 12:34:07 UTC
Success https://copr.fedorainfracloud.org/coprs/g/python/python3.9/build/1256412/ or not?

Comment 3 Miro Hrončok 2020-03-19 12:59:38 UTC
TY