Bug 1800947

Summary: Clone VM action fails while the engine.log and events report success
Product: [oVirt] ovirt-engine Reporter: Polina <pagranat>
Component: BLL.VirtAssignee: Lucia Jelinkova <ljelinko>
Status: CLOSED CURRENTRELEASE QA Contact: Polina <pagranat>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.4.0CC: bugs, ljelinko, rbarry
Target Milestone: ovirt-4.4.0Flags: pm-rhel: ovirt-4.4+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.0 gitb5b5c99ca2f Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:01:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Polina 2020-02-09 09:46:21 UTC 
Created attachment 1661963 [details]
engine.log

Description of problem: According to the engine.log it looks like VM is created by clone action, but it is really not 

Version-Release number of selected component (if applicable): 
http://bob-dr.lab.eng.brq.redhat.com/builds/4.4/rhv-4.4.0-18

How reproducible:100%


Steps to Reproduce:
1. Select existent VM in Compute/Virtual Machines window. The existent VM was created on the base of oficial latest-rhel-guest-image-8.1-infra template. Select Clone VM, insert the new name for the VM.

Actual results:
as result you got error -
2020-02-09 11:12:38,423+02 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-17) [75cc5844] EVENT_ID: USER_FAILED_ADD_VM(57), Failed to create VM test (User: admin@internal-authz).

Then you see notification in engine.log and in the Events that says it succeeds 

2020-02-09 11:13:16,764+02 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-23) [] EVENT_ID: USER_ADD_VM_FINISHED_SUCCESS(53), VM test creation has been completed.

The VM is not created really . it is seen neither in the UI window nor in get VMs response.

Expected results: VM cloned.

Additional info:
Comment 1 Lucia Jelinkova 2020-02-10 13:31:03 UTC 
I could reproduce locally the problem when cloning VM created from a template. This was related to the fact that the template of a cloned VM is set to "Blank".

https://github.com/oVirt/ovirt-engine/commit/9957082031a1352cc7437298d429a825c43fb4c2

However, for me, the UI correctly displayed a dialog explaining the problem (With message: The requested template doesn't belong to the same base template as the original template.).
Comment 2 Polina 2020-03-25 08:25:38 UTC 
Verified on http://bob-dr.lab.eng.brq.redhat.com/builds/4.4/rhv-4.4.0-23 

The original problem (VM not cloned) is solved. 

There is a minor issue in UI: upon click 'Clone' for the selected desktop VM , the open Edit window for the cloned VM automatically sets the cloned VM as a Server. this could be changed by the user if he noticed. 

please let me know if we want to leave it this way.
Comment 3 Lucia Jelinkova 2020-03-25 11:35:44 UTC 
The new VM has to be configured the same way as the original one - so this should be fixed. I'll look into it.
Comment 4 Polina 2020-03-25 12:14:42 UTC 
so, I verify this one and will open a new one for webui
Comment 5 Sandro Bonazzola 2020-05-20 20:01:35 UTC 
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Comment 6 Red Hat Bugzilla 2023-09-14 05:52:11 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days