Bug 1800963

Summary:	Review Request: SDL2_sound - SDL2_sound is SDL_sound but with a SDL2 backend.
Product:	[Fedora] Fedora	Reporter:	François Cami <fdc>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fcami, fdc, fedora, package-review, ppisar
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-23 21:38:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description François Cami 2020-02-09 14:29:05 UTC

Spec URL: https://fcami.fedorapeople.org/srpms/SDL2_sound.spec
SRPM URL: https://fcami.fedorapeople.org/srpms/SDL2_sound-1.0.4-20180720.9262f9205898.1.fc31.src.rpm
Description: SDL2_sound is SDL_sound but with a SDL2 backend. This is a library
that handles the decoding of several popular sound file formats, such
as .WAV and .MP3. It is meant to make the programmer's sound playback
tasks simpler. The programmer gives SDL2_sound a file-name, or feeds it
data directly from one of many sources, and then reads the decoded
waveform data back at her leisure. If resource constraints are a
concern, SDL2_sound can process sound data in programmer-specified
blocks. Alternately, SDL2_sound can decode a whole sound file and hand
back a single pointer to the whole waveform. SDL2_sound can also handle
sample rate, audio format, and channel conversion on-the-fly and
behind-the-scenes.
Fedora Account System Username: fcami

Notes: This is a snapshot release taken from the head of https://hg.icculus.org/icculus/SDL_sound . The main change is the removal of the included and heavily reworked libmodplug as documented in the spec.

Comment 1 François Cami 2020-02-09 23:42:12 UTC

Please consider this WIP - it's not ready for a full review yet.

Comment 2 Artur Frenszek-Iwicki 2020-09-23 14:10:58 UTC

>%build
>%cmake [...]
>%make_build
> 
>%install
>%make_install
I think it's preferred to use %{cmake_build} and %{cmake_install}.
https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/#_available_macros

>%package -n %{name}-devel
>Requires:       %{name} = %{version}-%{release}
This should be an archful dependency - "%{name}%{?_isa} - %{version}-%{release}".

>Conflicts:      SDL_sound <= 1.0.3
Every other SDL add-on (_ttf, _mixer, etc.) can be installed in both SDL and SDL2 versions.
Would it be possible to patch this so it can be installed alongside "old" SDL_sound?

Comment 3 François Cami 2020-09-23 21:38:40 UTC

Thanks Artur.

I don't remember why I added the conflict. 
I am not interested in working on this anymore, please feel free to pull the SPEC/SRPM and open another review request.