Bug 1800994

Summary: Review Request: raysession - Ray Session is a GNU/Linux session manager for audio programs
Product: [Fedora] Fedora Reporter: Erich Eickmeyer <erich>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, quantum.analyst
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-10 17:32:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
RaySession.spec none

Description Erich Eickmeyer 2020-02-09 21:56:59 UTC 
Spec URL: https://pagure.io/RaySession/blob/master/f/RaySession.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/RaySession/fedora-rawhide-x86_64/01231389-RaySession/RaySession-0.8.3-1.src.rpm

Description: Ray Session is a GNU/Linux session manager for audio programs as Ardour, Carla, QTractor, Non-Timeline, etc...

It uses the same API as Non Session Manager, so programs compatible with NSM are also compatible with Ray Session. As Non Session Manager, the principle is to load together audio programs, then be able to save or close all documents together.

Ray Session offers a little more:

- Factory templates for NSM and LASH compatible applications
- Possibility to save any client as template
- Save session as template
- Name files with a prettier way
- remember if client was started or not
- Abort session almost anytime
- Change Main Folder of sessions on GUI
- Possibility to KILL client if clean exit is too long
- Open Session Folder button (open default file manager)

Ray Session is being developed by houston4444, using Python3 and Qt5.

Fedora Account System Username: eeickmeyer
Comment 1 Erich Eickmeyer 2020-02-09 21:58:59 UTC 
Created attachment 1661993 [details]
RaySession.spec
Comment 2 Elliott Sales de Andrade 2020-02-09 23:03:23 UTC 
You need to link to the raw copy of the spec and srpm so that fedora-review works.

Lower-case is preferred, though not required. However, you should be consistent about it; this review should be for RaySession, not raysession, and the %global pname seems unused.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity

All the %globals at the top of the spec are unnecessary. You are building a tagged release, not a snapshot.

BuildArch, not BuildArchitectures.

I don't know why you have filtering for libjack, there is neither libjack.so listed in files, nor any compiled files that would cause there to be Requires on it.

INSTALL.md is not a necessary %doc. COPYING should be marked as %license instead.
Comment 3 Elliott Sales de Andrade 2020-02-09 23:04:22 UTC 
Forgot a couple things:

Release is missing %{?dist}

Add a comment describing patch status https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/
Comment 4 Erich Eickmeyer 2020-02-09 23:38:04 UTC 
Thank you so much Elliott! My first time submitting a package to Fedora. Most of my prior packaging experience is in the Debian/Ubuntu system, so this is a bit of a learning curve, albiet not too steep of one.

Shall I close this and submit a new review request bug? I got the raw spec file at https://pagure.io/RaySession/raw/master/f/RaySession.spec and made the changes you reqested.
Comment 5 Elliott Sales de Andrade 2020-02-11 07:29:19 UTC 
No need to open a new bug, just post the new links to the spec and srpm in the future.

*** This bug has been marked as a duplicate of bug 1801352 ***