Bug 1801194

Summary: User experience of ignition/Custom script textbox is low.
Product: [oVirt] ovirt-engine Reporter: Nisim Simsolo <nsimsolo>
Component: Frontend.WebAdminAssignee: Lucia Jelinkova <ljelinko>
Status: CLOSED CURRENTRELEASE QA Contact: Nisim Simsolo <nsimsolo>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.4.0CC: bugs, nsimsolo, rbarry
Target Milestone: ovirt-4.4.0Flags: pm-rhel: ovirt-4.4+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine 4.4.0-26 b5b5c99ca2f Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:01:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
First view of edit VM custom script textbox (textbox size if only 2 lines)
none
not all lines are visible
none
dialog is out of scale if using "long" lines
none
After saving VM configuration, the textbox size changed again to 2 lines although there are more lines now in the textbox none

Description Nisim Simsolo 2020-02-10 11:56:01 UTC 
Description of problem:
Currently, when editing VM and trying to add custom script or ignition script, the user experience of this textbox is low:
1. The text box default size is of 2 lines (while there is no sciprt usually smaller than 3 lines).
2. Entering more than 2 lines, the upper lines disappear and needs to be scrolled back using arrow keys or by  changing textbox size using mouse in order to see them.
3. Same as 2. for copy&paste into the textbox.
4. Even when changing the textbox size with the mouse, still, the edit VM dialog page needs to be scrolled down in order to see everything.
5. After applying edit VM (saving configuration) and opening edit VM dialog, again, the textbox size is 2 line although there's a bigger script inside there.

Version-Release number of selected component (if applicable):
ovirt-engine-4.4.0-0.19.master.el7
vdsm-4.40.2-1.el8ev.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Edit VM -> initial run -> check "use cloud-init"/"ignition" checkbox.
2. Enter script in "custom script"/"ignition script"
3.

Actual results:
User experience of the textbox is poor

Expected results:
It should be easier and more convenient to use this field

Additional info:
screenshots attached
Comment 1 Nisim Simsolo 2020-02-10 12:00:58 UTC 
Created attachment 1662126 [details]
First view of edit VM custom script textbox (textbox size if only 2 lines)
Comment 2 Nisim Simsolo 2020-02-10 12:01:40 UTC 
Created attachment 1662127 [details]
not all lines are visible
Comment 3 Nisim Simsolo 2020-02-10 12:02:26 UTC 
Created attachment 1662128 [details]
dialog is out of scale if using "long" lines
Comment 4 Nisim Simsolo 2020-02-10 12:03:27 UTC 
Created attachment 1662130 [details]
After saving VM configuration, the textbox size changed again to 2 lines although there are more lines now in the textbox
Comment 5 Ryan Barry 2020-02-11 01:23:44 UTC 
Lucia, want to see if we can make the UX more like cloud-init?
Comment 6 Nisim Simsolo 2020-03-23 07:30:31 UTC 
Verification builds:
ovirt-engine-4.4.0-0.26.master.el8ev.noarch
vdsm-4.40.7-1.el8ev.x86_64

cloud-init/ignition Text box is not bigger and more easier to use.
OCP bootstrap script for example, is now more nice to read/edit.
Comment 7 Sandro Bonazzola 2020-05-20 20:01:48 UTC 
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.