Bug 1801264 (CVE-2020-5217)

Summary:	CVE-2020-5217 rubygem-secure_headers: directive injection when using dynamic overrides with user input
Product:	[Other] Security Response	Reporter:	Guilherme de Almeida Suckevicz <gsuckevi>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	bbuckingham, bcourt, bkearney, btotty, dmetzger, gblomqui, gmccullo, gtanzill, hhudgeon, jfrey, jhardy, kdixon, lzap, mmccune, obarenbo, rchan, rjerrido, roliveri, simaishi, smallamp, sokeeffe
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	A flaw was found in rubygem-secure_headers in versions prior to 6.2.0, 5.1.0, and 3.8.0. If user-supplied input was passed into append/override_content_security_policy_directives, a semicolon could be injected leading to directive injection which could be used to override a script-src directive. The highest threat from this vulnerability is to data integrity.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 14:21:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1802503, 1802504, 1866306
Bug Blocks:	1801265

Description Guilherme de Almeida Suckevicz 2020-02-10 14:29:23 UTC

In Secure Headers (RubyGem secure_headers), a directive injection vulnerability is present in versions before 3.8.0, 5.1.0, and 6.2.0. If user-supplied input was passed into append/override_content_security_policy_directives, a semicolon could be injected leading to directive injection. This could be used to e.g. override a script-src directive. Duplicate directives are ignored and the first one wins. The directives in secure_headers are sorted alphabetically so they pretty much all come before script-src. A previously undefined directive would receive a value even if SecureHeaders::OPT_OUT was supplied. The fixed versions will silently convert the semicolons to spaces and emit a deprecation warning when this happens. This will result in innocuous browser console messages if being exploited/accidentally used. In future releases, we will raise application errors resulting in 500s. Depending on what major version you are using, the fixed versions are 6.2.0, 5.1.0, 3.8.0.

References:
https://github.com/twitter/secure_headers/security/advisories/GHSA-xq52-rv6w-397c
https://github.com/twitter/secure_headers/issues/418

Upstream commit:
https://github.com/twitter/secure_headers/commit/936a160e3e9659737a9f9eafce13eea36b5c9fa3

Comment 2 Yadnyawalk Tale 2020-02-13 10:01:36 UTC

External References:

https://github.com/twitter/secure_headers/security/advisories/GHSA-xq52-rv6w-397c

Comment 8 Eric Christensen 2020-08-24 16:21:00 UTC

Statement:

Satellite 6 ships Secure Header rubygem, however it does not accept any user input in override_content_security_policy_directive or append_content_security_policy_directive. All directives are hard-coded and therefore, Satellite 6 is not vulnerable to this CVE. We may update this rubygem in future release.

Comment 9 errata-xmlrpc 2020-10-27 12:55:55 UTC

This issue has been addressed in the following products:

  Red Hat Satellite 6.7 for RHEL 8

Via RHSA-2020:4366 https://access.redhat.com/errata/RHSA-2020:4366

Comment 10 Product Security DevOps Team 2020-10-27 14:21:20 UTC

This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2020-5217