Bug 1801286 (CVE-2020-5216)

Summary:	CVE-2020-5216 rubygem-secure_headers: limited header injection when using dynamic overrides with user input
Product:	[Other] Security Response	Reporter:	Guilherme de Almeida Suckevicz <gsuckevi>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	bbuckingham, bcourt, bkearney, btotty, dmetzger, gblomqui, gmccullo, gtanzill, hhudgeon, jfrey, jhardy, kdixon, lzap, mmccune, obarenbo, rchan, rjerrido, roliveri, simaishi, smallamp, sokeeffe
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	A directive injection vulnerability was found in Secure Headers RubyGem before versions 3.9.0, 5.2.0, and 6.3.0. If user-supplied input was passed into the vulnerable function, a new line could be injected, leading to limited header injection, which could create a new Content Security Policy header in the HTTP response.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 14:21:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1802536, 1802537, 1866306
Bug Blocks:	1801287

Description Guilherme de Almeida Suckevicz 2020-02-10 15:00:41 UTC

In Secure Headers (RubyGem secure_headers), a directive injection vulnerability is present in versions before 3.9.0, 5.2.0, and 6.3.0. If user-supplied input was passed into append/override_content_security_policy_directives, a newline could be injected leading to limited header injection. Upon seeing a newline in the header, rails will silently create a new Content-Security-Policy header with the remaining value of the original string. It will continue to create new headers for each newline. This has been fixed in 6.3.0, 5.2.0, and 3.9.0.

Reference:
https://github.com/twitter/secure_headers/security/advisories/GHSA-w978-rmpf-qmwg

Upstream commit:
https://github.com/twitter/secure_headers/commit/301695706f6a70517c2a90c6ef9b32178440a2d0

Comment 2 Yadnyawalk Tale 2020-02-12 15:40:41 UTC

External References:

https://github.com/twitter/secure_headers/security/advisories/GHSA-w978-rmpf-qmwg

Comment 4 Yadnyawalk Tale 2020-02-18 10:15:13 UTC

Statement:

Satellite 6 ships Secure Header rubygem, however, it does not accept any user input in override_content_security_policy_directive or append_content_security_policy_directive. All directives are hard-coded and therefor Satellite 6 is not vulnerable to this CVE. We may update this rubygem in future release.

Comment 7 errata-xmlrpc 2020-10-27 12:55:46 UTC

This issue has been addressed in the following products:

  Red Hat Satellite 6.7 for RHEL 8

Via RHSA-2020:4366 https://access.redhat.com/errata/RHSA-2020:4366

Comment 8 Product Security DevOps Team 2020-10-27 14:21:24 UTC

This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2020-5216