Bug 180149
Summary: | Review Request: edje: A complex graphical design and layout library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
Component: | Package Review | Assignee: | Christian Iseli <Christian.Iseli> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-27 17:51:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 180052, 180058, 180102 | ||
Bug Blocks: | 163779 |
Description
Ignacio Vazquez-Abrams
2006-02-06 10:34:50 UTC
Why does bug 180056 (system-config-httpd references obsolete module names) block this? Because I'm blind. Good: - rpmlint is ok - name ok - spec name ok - packaging guidelines met - license ok - license matches actual license in package - license file in %doc - spec file in American English and legible - source matches upstream - builds, installs, runs, and uninstalls cleanly - BuildRequires ok - no locale to worry about - shared libs ok - -devel package ok - no relocation to worry about - no duplicated files - files perms ok - clean section ok - macro useage ok - package contains code - no large doc - %doc is only doc - builds in mock My machines here still run FC4, so I didn't check if the code actualy runs... but I'll trust you on this one. Why the empty %doc in the devel package ? I think %{_datadir}/%{name}/ is more explicit than %{_datadir}/%{name} but that's a matter of taste I guess... rpmlint says: E: edje non-executable-script /usr/share/edje/data/template/build_theme.sh 0644 E: edje non-executable-script /usr/share/edje/data/e_logo.sh 0644 W: edje-devel no-documentation which I think can be ignored. APPROVED. Built on FC5 and devel. |