Bug 1802274

Summary:	[OVNKubernetes] unsupported OVN upgrade from 4.3 to 4.4 fails due to app=ovnkube-master to name=ovnkube-master change
Product:	OpenShift Container Platform	Reporter:	Ross Brattain <rbrattai>
Component:	Networking	Assignee:	Ben Bennett <bbennett>
Networking sub component:	ovn-kubernetes	QA Contact:	zhaozhanqi <zzhao>
Status:	CLOSED WONTFIX	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	anusaxen, bjacot, lmohanty, wking, wzheng
Version:	4.3.z	Keywords:	Upgrades
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-05 14:01:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ross Brattain 2020-02-12 18:54:05 UTC

Description of problem:

From 4.3 to 4.4 we changed app=ovnkube-master to name=ovnkube-master in 
https://github.com/openshift/cluster-network-operator/pull/435
https://github.com/openshift/cluster-network-operator/pull/419

OVN is TP in 4.3, so upgrade is unsupported, but this change will break automation scripts.

Tracking bug for CI automation failures.

Version-Release number of selected component (if applicable):
4.4

How reproducible:
Always

Steps to Reproduce:
1. upgrade OVN 4.3 cluster to 4.4
2.
3.

Actual results:

Error while updating operator configuration: could not apply (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: could not update object (apps/v1, Kind=DaemonSet) openshift-ovn-kubernetes/ovnkube-master: DaemonSet.apps "ovnkube-master" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"ovnkube-master"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable


Expected results:

upgrade succeeds

Additional info:

Comment 2 Ross Brattain 2020-02-27 03:49:06 UTC

Looks like this was fixed in https://github.com/openshift/cluster-network-operator/pull/483

Comment 3 Ross Brattain 2020-02-27 18:27:42 UTC

OVN 4.3 to 4.4 upgrade completed successfully with  4.3.0-0.nightly-2020-02-27-054508  to  4.4.0-0.nightly-2020-02-27-070700

Comment 4 Wenjing Zheng 2020-03-04 11:57:10 UTC

*** Bug 1809997 has been marked as a duplicate of this bug. ***

Comment 5 zhaozhanqi 2020-03-04 12:03:04 UTC

now this issue only happen on 4.3.3 to latest 4.3 nightly build and 4.4 version. 
do we have customer is using 4.3.3 for OVN since 4.3.3 is TP I guess? if no. I guess we do not need to do upgrade for it.

Comment 6 Lalatendu Mohanty 2020-03-04 12:14:57 UTC

*** Bug 1809997 has been marked as a duplicate of this bug. ***

Comment 7 Ben Bennett 2020-03-05 14:01:02 UTC

Upgrades from 4.3 to 4.4 are not supported... the only supported customer will be doing a reinstall and will not be upgrading.

Comment 8 Ben Bennett 2020-04-14 14:35:25 UTC

*** Bug 1823483 has been marked as a duplicate of this bug. ***