Bug 1802303

Summary: Documentation is missing the information on how to set OCS as infra
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Eran Tamir <etamir>
Component: documentationAssignee: Olive Lakra <olakra>
Status: CLOSED CURRENTRELEASE QA Contact: shylesh <shmohan>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.2CC: asriram, bkunal, ebenahar, kbader, khartsoe, nberry, ocs-bugs, olakra, pbalogh, puebele, rcyriac
Target Milestone: ---   
Target Release: OCS 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-18 11:54:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1880905    

Comment 6 Martin Bukatovic 2020-03-13 19:12:51 UTC
I see that 2 notes as listed in comment 5 has been added to the docs. And that these notes communicates what Eran is suggesting in the description of this bug. 

That said, I don't understand the purpose nor the reasoning behind this request.

What does sentence "to be counted towards subscription" exactly mean?
What is a customer reading "You also need to make sure that the CSI pods are running on the worker nodes." expected to do?
Why would customer have a  CSI pods in Pending state?

I also don't see answer to Laura's question from comment 2.

Comment 7 Martin Bukatovic 2020-03-13 19:14:08 UTC
Do we implement the suggestions as described here in ocs-ci installation?

Comment 8 Petr Balogh 2020-03-17 08:50:35 UTC
Sorry but I didn't get what OCS as infra exactly means here as well.
Is this somewhere described defined in our doc as if not this should be defined to let customer understand it correctly.

I tried to find some openshift documentation about infra nodes and usually found labels:
node-role.kubernetes.io/infra=true
For example here:
https://docs.openshift.com/container-platform/3.10/admin_guide/manage_nodes.html#infrastructure-nodes

But you refer to:
node-role.kubernetes.io/infra=''

I think we should be consistent with other doc.

+1 for Martins comment about better explanation of: What does sentence "to be counted towards subscription" exactly mean?

If I am a customer I would like to know differences of running OCS as infra and normal use case where we don't set the above.


About the infra nodes which let me more understand the logic behind that is described for example here:
https://stackoverflow.com/questions/43844511/purpose-of-adding-openshift-intrastructure-nodes

But can we describe which exact pods will be running on those infra pods? Will there be running just some of them or all OCS pods?
Thanks

Comment 9 Petr Balogh 2020-03-17 08:54:02 UTC
(In reply to Martin Bukatovic from comment #7)
> Do we implement the suggestions as described here in ocs-ci installation?

In reply to this. We currently do not do anything mentioned above as we usually have 3 masters / 3 worker nodes  and we don't have separated nodes for infra.

Is my understanding correct that for this approach we should have at least 3 masters 3 workers 3 infra nodes?

Is there some minimum requirements for infra nodes from OCS point of view and where is it documented?

Comment 12 Martin Bukatovic 2020-03-20 18:42:40 UTC
The current state of the docs as referenced in comment 5 via preview url doesn't communicate whole context of the problem, and it's unlikely that customers will understand it in it's current form.

>>> ASSIGNED

Note that this is failedqe mainly because of a failed planning (the bug wasn't clarified enough to qualify to get a qe ack).

After evaluation the feedback from Eran and Petr, I believe that this requires:

- more careful thinking and wording to make sure we convey the information as planned (eg. I don't think that the note about particular problem with tainted notes should be listed among installation requirements)
- testing coordination with infra team

And based on that I'm suggesting to drop this out of OCS 4.3.

That said, we could consider this 4.3.z doc only async to get this out asap, when the purpose is more clarified.

Comment 15 Elad 2020-03-30 13:39:11 UTC
Suggesting pushing the content addition asked in this BZ to post 4.3 GA. We need to do better preparation and coordination as Martin mentioned.
Olive, Ken, can we revert the docs changes so they will be included in a docs bactch update / z-stream for 4.3?

I'm not changing the bug status for now.

Comment 17 Martin Bukatovic 2020-04-06 09:50:18 UTC
Dropping qa ack as noted in comment 12, to make sure status of this bug is correct.

Comment 18 Elad 2020-04-14 08:37:20 UTC
Anjana/Rejy, could you please re-target? 
Also, suggest moving to NEW

Comment 21 Martin Bukatovic 2020-04-16 18:29:34 UTC
*** Bug 1823895 has been marked as a duplicate of this bug. ***

Comment 32 shylesh 2020-12-08 19:42:56 UTC
All the requested changes are in the doc and looks good. Marking this as verified.

Comment 33 Rejy M Cyriac 2020-12-18 11:54:15 UTC
OCS 4.6.0 GA completed on 17 December 2020