Bug 1802343 (golang-github-alangpierce-forceexport)

Well this looks like a terrible little package...

Approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Expat License", "Unknown or
     generated". 3 files have unknown license. Detailed output of
     licensecheck in 1802343-golang-github-alangpierce-forceexport/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-alangpierce-forceexport-0-0.1.20200212git8f1d694.fc33.src.rpm
golang-github-alangpierce-forceexport.src: W: spelling-error Summary(en_US) unexported -> unreported, reexported, exported
golang-github-alangpierce-forceexport.src: W: no-%build-section
golang-github-alangpierce-forceexport.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables!
1 packages and 0 specfiles checked; 1 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
golang-github-alangpierce-forceexport-devel.noarch: W: spelling-error Summary(en_US) unexported -> unreported, reexported, exported
golang-github-alangpierce-forceexport-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/alangpierce/go-forceexport/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


Source checksums
----------------
https://github.com/alangpierce/go-forceexport/archive/8f1d6941cd755b975763ddb1f836561edddac2b8/go-forceexport-8f1d6941cd755b975763ddb1f836561edddac2b8.tar.gz :
  CHECKSUM(SHA256) this package     : ca55bf0ad62151740e644e0722595c2571bf82f3c2be86e80e04947c325761bd
  CHECKSUM(SHA256) upstream package : ca55bf0ad62151740e644e0722595c2571bf82f3c2be86e80e04947c325761bd


Requires
--------
go-filesystem
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1


Provides
--------
golang(github.com/alangpierce/go-forceexport) = 0-0.1.20200212git8f1d694.fc33
golang(github.com/alangpierce/go-forceexport)(commit=8f1d6941cd755b975763ddb1f836561edddac2b8) = 0-0.1.20200212git8f1d694.fc33
golang-github-alangpierce-forceexport-devel = 0-0.1.20200212git8f1d694.fc33
golang-ipath(github.com/alangpierce/go-forceexport) = 0-0.1.20200212git8f1d694.fc33
golang-ipath(github.com/alangpierce/go-forceexport)(commit=8f1d6941cd755b975763ddb1f836561edddac2b8) = 0-0.1.20200212git8f1d694.fc33


Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07
Command line :/usr/bin/fedora-review -b 1802343 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: Ocaml, Haskell, SugarActivity, R, Python, fonts, Perl, C/C++, PHP, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alangpierce-forceexport

FEDORA-2020-c097084089 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c097084089

FEDORA-2020-e3f4e59e1a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e3f4e59e1a

golang-github-alangpierce-forceexport-0-0.1.20200304git8f1d694.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-c097084089

golang-github-alangpierce-forceexport-0-0.1.20200304git8f1d694.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e3f4e59e1a

golang-github-alangpierce-forceexport-0-0.1.20200304git8f1d694.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

golang-github-alangpierce-forceexport-0-0.1.20200304git8f1d694.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.

golang-github-alangpierce-forceexport-0-0.1.20200304git8f1d694.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.