Bug 1802370 (golang-github-francoispqt-gojay)
| Summary: | Review Request: golang-github-francoispqt-gojay - Fastest JSON encoder/decoder with powerful stream API for Golang | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert-André Mauchin 🐧 <zebob.m> |
| Component: | Package Review | Assignee: | Olivier Lemasle <o.lemasle> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | carl, o.lemasle, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | o.lemasle:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-06 22:01:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1802357, 1802362 | ||
| Bug Blocks: | 1803692 | ||
|
Description
Robert-André Mauchin 🐧
2020-02-13 02:43:37 UTC
Any update on this review Olivier? Sorry for the delay, I was waiting to golang-github-viant-toolbox to be "unbootstrapped", since golang-github-francoispqt-gojay depends on golang(github.com/viant/toolbox/url), which is not provided by golang-github-viant-toolbox's bootstrap build. Finally, I built it myself locally (with its dependencies golang-github-viant-assertly and golang-github-viant-toolbox unbootstrapped). Just one thing: is it normal to package the examples directory as %godoc even in the *binary* package? golang-github-francoispqt-gojay-1.2.13-1.fc33.x86_64.rpm /usr/bin/gojay /usr/lib/.build-id /usr/lib/.build-id/8b /usr/lib/.build-id/8b/605f02b9d37b065476634aa3fa482a14edb804 /usr/share/doc/golang-github-francoispqt-gojay /usr/share/doc/golang-github-francoispqt-gojay/README.md /usr/share/doc/golang-github-francoispqt-gojay/examples /usr/share/doc/golang-github-francoispqt-gojay/examples/encode-decode-map /usr/share/doc/golang-github-francoispqt-gojay/examples/encode-decode-map/main.go /usr/share/doc/golang-github-francoispqt-gojay/examples/fuzz /usr/share/doc/golang-github-francoispqt-gojay/examples/fuzz/Makefile /usr/share/doc/golang-github-francoispqt-gojay/examples/fuzz/main.go /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/Makefile /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/README.md /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/gojay /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/gojay/main.go /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/post.lua /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/standard /usr/share/doc/golang-github-francoispqt-gojay/examples/http-benchmarks/standard/main.go /usr/share/doc/golang-github-francoispqt-gojay/examples/http-json /usr/share/doc/golang-github-francoispqt-gojay/examples/http-json/main.go /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/client /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/client/client.go /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/comm /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/comm/comm.go /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/main.go /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/server /usr/share/doc/golang-github-francoispqt-gojay/examples/websocket/server/server.go /usr/share/licenses/golang-github-francoispqt-gojay /usr/share/licenses/golang-github-francoispqt-gojay/LICENSE Otherwise: - MIT license ok - Spec + changelog format ok - Naming guidelines + packaging guidelines ok - Builds in mock ok Rpmlint ------- golang-github-francoispqt-gojay.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance golang-github-francoispqt-gojay.x86_64: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance golang-github-francoispqt-gojay.x86_64: W: no-manual-page-for-binary gojay 2 packages and 0 specfiles checked; 0 errors, 3 warnings. (In reply to Olivier Lemasle from comment #2) > Sorry for the delay, I was waiting to golang-github-viant-toolbox to be > "unbootstrapped", since golang-github-francoispqt-gojay depends on > golang(github.com/viant/toolbox/url), which is not provided by > golang-github-viant-toolbox's bootstrap build. > > Finally, I built it myself locally (with its dependencies > golang-github-viant-assertly and golang-github-viant-toolbox unbootstrapped). > > Just one thing: is it normal to package the examples directory as %godoc > even in the *binary* package? > This is not necessary no. New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-francoispqt-gojay.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-francoispqt-gojay-1.2.13-1.fc33.src.rpm Please take a look at it again if you have the time. Hi, did you change anything? Spec file and srpm seems identical to the previous ones. In particular, the binary package contains the whole "examples" directory in documentation. New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-francoispqt-gojay.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-francoispqt-gojay-1.2.13-1.fc33.src.rpm Sorry it's been a while I need to build golang-github-viant-assertly first then Unboostrap golang-github-viant-toolbox. I've unboostrapped golang-github-viant-toolbox: https://koji.fedoraproject.org/koji/buildinfo?buildID=1536723 This should be good for review now. Thanks again! Thanks, package approved.
- MIT license ok
- Spec + changelog format ok
- Naming guidelines + packaging guidelines ok
- Builds in mock ok
- Documentation ok
Rpmlint
-------
Checking: golang-github-francoispqt-gojay-1.2.13-1.fc33.x86_64.rpm
golang-github-francoispqt-gojay-devel-1.2.13-1.fc33.noarch.rpm
golang-github-francoispqt-gojay-debuginfo-1.2.13-1.fc33.x86_64.rpm
golang-github-francoispqt-gojay-debugsource-1.2.13-1.fc33.x86_64.rpm
golang-github-francoispqt-gojay-1.2.13-1.fc33.src.rpm
golang-github-francoispqt-gojay.x86_64: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
golang-github-francoispqt-gojay.x86_64: W: no-manual-page-for-binary gojay
golang-github-francoispqt-gojay-devel.noarch: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
golang-github-francoispqt-gojay-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/francoispqt/gojay/.goipath
golang-github-francoispqt-gojay.src: W: spelling-error %description -l en_US performant -> perform ant, perform-ant, performance
5 packages and 0 specfiles checked; 0 errors, 5 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-francoispqt-gojay FEDORA-2020-b1416f579d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1416f579d FEDORA-2020-37df752a17 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-37df752a17 FEDORA-2020-b1416f579d has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-b1416f579d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1416f579d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-37df752a17 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-37df752a17 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-37df752a17 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-37df752a17 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-b1416f579d has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |