Bug 1802554

Summary: [SSP] cpu-feature-lahf_lm and Conroe are enabled on one worker (test issue)
Product: Container Native Virtualization (CNV) Reporter: Ruth Netser <rnetser>
Component: SSPAssignee: Karel Šimon <ksimon>
Status: CLOSED ERRATA QA Contact: Ruth Netser <rnetser>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.2.0CC: cnv-qe-bugs, fdeutsch, ipinto, ksimon, sgott
Target Milestone: ---   
Target Release: 2.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-28 19:09:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ruth Netser 2020-02-13 11:56:49 UTC
Description of problem:
Environment with bare-metal, RHEL7 workers.
One worker (out of 3) has feature.node.kubernetes.io/cpu-feature-lahf_lm=true
This should be set to false, as it is part of Penryn (which is set as minCPU in config map 

Version-Release number of selected component (if applicable):
kubevirt-hyperconverged-operator.v2.2.0

How reproducible:
Unknown

Steps to Reproduce:
- No specific steps to reproduce
1. Check min cpu value in configmap:
# oc get cm kubevirt-cpu-plugin-configmap -n openshift-cnv -oyaml
apiVersion: v1
data:
  cpu-plugin-configmap.yaml: |-
    obsoleteCPUs:
      - "486"
      - "pentium"
      - "pentium2"
      - "pentium3"
      - "pentiumpro"
      - "coreduo"
      - "n270"
      - "core2duo"
      - "Conroe"
      - "athlon"
      - "phenom"
    minCPU: "Penryn"

2. Create a VM and check min CPU xml

==============================
#  cat /usr/share/libvirt/cpu_map/x86_Penryn.xml
<cpus>
  <model name='Penryn'>
    <signature family='6' model='23'/> <!-- 010670 -->
    <signature family='6' model='29'/> <!-- 0106d0 -->
    <vendor name='Intel'/>
    <feature name='apic'/>
    <feature name='clflush'/>
    <feature name='cmov'/>
    <feature name='cx16'/>
    <feature name='cx8'/>
    <feature name='de'/>
    <feature name='fpu'/>
    <feature name='fxsr'/>
    <feature name='lahf_lm'/>
    <feature name='lm'/>
    <feature name='mca'/>
    <feature name='mce'/>
    <feature name='mmx'/>
    <feature name='msr'/>
    <feature name='mtrr'/>
    <feature name='nx'/>
    <feature name='pae'/>
    <feature name='pat'/>
    <feature name='pge'/>
    <feature name='pni'/>
    <feature name='pse'/>
    <feature name='pse36'/>
    <feature name='sep'/>
    <feature name='sse'/>
    <feature name='sse2'/>
    <feature name='sse4.1'/>
    <feature name='ssse3'/>
    <feature name='syscall'/>
    <feature name='tsc'/>
  </model>
</cpus>

=====================================

3. Check nodes CPU labels (see output below)


Actual results:
One node has 
feature.node.kubernetes.io/cpu-feature-lahf_lm=true

This feature does not appear under node-labeller under annotations (node-labeller-feature.node.kubernetes.io)

Expected results:
cpu-feature-lahf_lm should be disabled / should not appear

Additional info:

See attached nodes yaml files

Comment 4 Karel Šimon 2020-04-08 12:09:27 UTC
Fixed in https://github.com/kubevirt/kubevirt/pull/3133

Comment 9 errata-xmlrpc 2020-07-28 19:09:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3194