Bug 1802610
Summary: | Create and document transition from Restraint-RHTS to Restraint | ||
---|---|---|---|
Product: | [Retired] Restraint | Reporter: | Martin Styk <mastyk> |
Component: | general | Assignee: | Carol Bouchard <cbouchar> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | master | CC: | asavkov, atomasov, bpeck, breilly, bxue, cbeer, cbouchar, dzickus, emcnabb, ftjahjad, jbastian, jhladky, jiyin, jjurca, jtluka, kkolakow, liwan, olichtne, osabart, rasibley, xzhou, yizhan, yoyang, zguo, zlang |
Target Milestone: | 0.2.1 | Keywords: | Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-05-20 07:24:02 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Martin Styk
2020-02-13 14:38:10 UTC
We are working on migrating our tests to remove legacy RHTS functions for CKI team. As we review tests we have found the following findings and would like to know best practice for migrating tests to remove RHTS. It might be possible that Restraint has or will have certain features to avoid having to update every single test unnecessarily. Later we can move this to a common place for folks to reference as they migrate from RHTS to Restraint. What needs to happen: 1.) Remove restraint-rhts 2.) Remove rhts_environment.sh source from tests, e.g. . /usr/share/beakerlib/beakerlib.sh || exit 1 3.) Move all rhts-* commands to rstrnt-* compatible commands: https://restraint.readthedocs.io/en/latest/commands.html# 4.) Various parameters will need to be manually set (ARCH, OUTPUFILE, HOSTNAME,...) or the tests will break, can this be added to restraint ? https://github.com/beaker-project/rhts/blob/master/bin/rhts-environment.sh 5.) Traditional Makefile will no longer work, will need to be migrated to Restraint's metadata, e.g. https://github.com/CKI-project/tests-beaker/blob/master/acpi/acpitable/Makefile https://restraint.readthedocs.io/en/latest/tasks.html#metadata What am I forgetting ? Is there a way to make this transition easier ? Step 2 should be: . /usr/bin/rhts-environment.sh . /usr/share/rhts-library/rhtslib.sh (In reply to Rachel Sibley from comment #1) > 2.) Remove rhts_environment.sh source from tests, e.g. > . /usr/share/beakerlib/beakerlib.sh || exit 1 Was this a copy/paste error, Rachel? I think you mean this line instead: . /usr/bin/rhts-environment.sh || exit 1 Hi Jeff, yes copy/paste error, see https://bugzilla.redhat.com/show_bug.cgi?id=1802610#c2 Hi Carol, here is the PR that Fendy is working on to transition CKI tests to remove rhts legacy support, would you mind taking a look to check that our approach is correct ? https://github.com/CKI-project/tests-beaker/pull/479 Thank you very much for this. I will look at what you provided. Hello, just wondering why do transition from Restraint-RHTS to Restraint? Would anyone like to explain? Hi, Some of the teams would like to get rid of all RHTS parts. This actually makes sense, because you can run Restraint jobs on any bare-metal machine / virtual machine. This means I can use Restraint in Beaker and then I will buy AWS bare metal solution and use pure Restraint to do the communication. restraint-rhts contains a lot of parts that shouldn't be used. For example, leveraging /mnt namespace for testing / keeping data / etc. Furthermore .. Task Library/RPMs. You don't really need RPMs for your tests. It is easier for everyone to start onboarding your team and telling them, push it to git and run it. We are not saying that you shouldn't use restraint-rhts, however, if you want to be more flexible, then you should consider the usage of pure restraint. (In reply to Martin Styk from comment #11) > Hi, > > Some of the teams would like to get rid of all RHTS parts. This actually > makes sense, because you can run Restraint jobs on any bare-metal machine / > virtual machine. > This means I can use Restraint in Beaker and then I will buy AWS bare metal > solution and use pure Restraint to do the communication. > > restraint-rhts contains a lot of parts that shouldn't be used. For example, > leveraging /mnt namespace for testing / keeping data / etc. > Furthermore .. Task Library/RPMs. You don't really need RPMs for your tests. > It is easier for everyone to start onboarding your team and telling them, > push it to git and run it. > > We are not saying that you shouldn't use restraint-rhts, however, if you > want to be more flexible, then you should consider the usage of pure > restraint. Got it, thanks! |