Bug 1803841

Summary: Failed "Specfile dist Usage Test" for subscription-manager-migration-data-2.0.50-1.el7
Product: Red Hat Enterprise Linux 7 Reporter: John Sefler <jsefler>
Component: subscription-manager-migration-dataAssignee: William Poteat <wpoteat>
Status: CLOSED ERRATA QA Contact: Red Hat subscription-manager QE Team <rhsm-qe>
Severity: unspecified Docs Contact:
Priority: high    
Version: 7.8CC: candlepin-bugs, cdonnell, csnyder, dtodorov, redakkan, wpoteat
Target Milestone: rcKeywords: EasyFix, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: subscription-manager-migration-data-2.0.53-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-29 19:23:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1744146    

Description John Sefler 2020-02-17 15:00:56 UTC
Description of problem:
As part of the release steps for subscription-manager-migration-data, we execute the TPS suite of tests that are integrated with the errata tool.

The following is a failing tps-srpmtest that is likely caused by a change in the spec file...


=== Specfile dist Usage Test =====================
DIST CHECK: %{dist} found instead of %{?dist} in: subscription-manager-migration-data-2.0.50-1.el7.src.rpm.spec
  Release string was: 1%{dist}
TPSHINT: Release engineering policy is to use %{?dist}.  This is a bug in the package being tested, and should be fixed before release.
TPSRESULT: Specfile dist Usage Test Returning: FAIL



Version-Release number of selected component (if applicable):
subscription-manager-migration-data-2.0.50-1.el7

How reproducible:


Steps to Reproduce:
Run the TPS test suite from the errata tool for advisory...
https://errata.devel.redhat.com/tps/errata_results/40222

Comment 4 Chris Snyder 2020-02-17 15:43:27 UTC
The workaround for this issue is to create a dist macro definition (as the only reason this would be an issue is if your system is missing one).

To do this create a file /etc/rpm/macros.dist_custom with the following contents (for RHEL 7, less the triple quotes):
"""
# dist macros.

%rhel 7
%dist .el7
%el7 1
"""

Comment 11 John Sefler 2020-04-13 18:31:00 UTC
Verifying version...
[root@hpe-dl380pgen8-02-vm-4 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.9 Beta (Maipo)
[root@hpe-dl380pgen8-02-vm-4 ~]# rpm -q subscription-manager-migration-data
subscription-manager-migration-data-2.0.53-1.el7.noarch
[root@hpe-dl380pgen8-02-vm-4 ~]# rpm -q subscription-manager-migration-data --changelog | grep 1803841
- 1803841: Correct spec release value syntax (wpoteat)
- 1803841: Correct spec release value syntax (wpoteat)


The original failing TPS test suite from comment 0 is currently passing in the errata tool for the RHEL-7.9.0 advisory...
https://errata.devel.redhat.com/tps/errata_results/43925

For each row of variant/arch, open the TPS results and you will find Passing results for tps-srpmtest / Specfile dist Usage Test...

=== Specfile dist Usage Test =====================
begin at 04/06/2020 18:33:41 on x86-64-7c-v1.ss.eng.bos.redhat.com
end test at Mon Apr  6 18:33:41 EDT 2020 on x86-64-7c-v1.ss.eng.bos.redhat.com
TPSRESULT: Specfile dist Usage Test Returning: PASS

moving to VERIFIED

Comment 13 errata-xmlrpc 2020-09-29 19:23:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (subscription-manager bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3866