Bug 1804123

Summary:	Incorrectly shows enabled extensions as disabled after enable-all
Product:	Red Hat Enterprise Linux 8	Reporter:	Martin Krajnak <mkrajnak>
Component:	gnome-tweaks	Assignee:	Milan Crha <mcrha>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.2	CC:	jkoten, tpelka, tpopela
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.0
Hardware:	x86_64
OS:	All
Whiteboard:
Fixed In Version:	gnome-tweaks-3.28.1-7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 16:10:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1739559

Description Martin Krajnak 2020-02-18 09:29:37 UTC

Description of problem:
There's a "master" switch for extensions in gnome-tweaks, when it is used to turn all extensions back on in the new fresh instance of Tweaks, it fails to show which extensions are enabled. For more see the reproducer.

Version-Release number of selected component (if applicable):
gnome-tweaks-3.28.1-6.el8.noarch
gnome-shell-extension-window-list-3.32.1-10.el8.noarch

How reproducible:
always

Steps to Reproduce:
1.Run Tweaks
2.Go to extensions and enable random extensions, or just only one
3.Use the "master" switch to disabled at extensions at once, 
4.Close Tweaks
5.Run Tweaks
6.Enable all extensions via the same switch

Actual results:
The extensions are loaded, enabled but they are not listed as enabled in tweaks.

Workaround:
If you close Tweaks, run Tweaks again, extensions are listed properly.

Expected results:
Tweaks should refresh the extension list and show the proper state.

Additional info:
I know that extensions are being dropped upstream, but extensions in Tweaks will live further in RHEL8, so it would be nice to fix this. Especially if you consider, that several times when I was asked to debug something, the first thing I was asked was to turn of all extensions.

Comment 1 Milan Crha 2020-02-18 09:45:37 UTC

Thanks for a bug report. I see it's still broken in gnome-tweaks-3.34.0-2.fc32 and it seems like there's no upstream fix to backport (I checked opened merge requests too). I'm not sure whether it's a good idea to maintain a custom patch on top of an "upstream dead code", but if it'll be a simple fix, then it's fine. I'll let you know when I know more.

Comment 2 Milan Crha 2020-02-18 10:36:07 UTC

Okay, I've pretty simple fix for this, thus let's do it.

Comment 5 Martin Krajnak 2020-02-18 14:40:52 UTC

gnome-tweaks-3.28.1-7.el8.noarch

Comment 7 errata-xmlrpc 2020-04-28 16:10:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:1766