Bug 1804440

Summary: VDOOperation ImportOperation should not persist the config file w/ associated transactional remove
Product: Red Hat Enterprise Linux 8 Reporter: bjohnsto
Component: vdoAssignee: bjohnsto
Status: CLOSED ERRATA QA Contact: Filip Suba <fsuba>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.3CC: awalsh, fsuba
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 6.2.3.26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 02:01:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description bjohnsto 2020-02-18 20:23:10 UTC
Description of problem:

The code

    transaction = Transaction.transaction()
    vdo.importDevice()
    transaction.addUndoStage(vdo.remove)
    conf.persist()

is superfluous in that VDOService::importDevice maintains the configuration file in the correct state by persisting it where appropriate including removing the imported device in the event of an error.
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. 
2.
3.

Actual results:


Expected results:


Additional info:

Comment 5 Filip Suba 2020-08-21 09:21:17 UTC
Verified with vdo-6.2.3.114-14.el8. Regression testing passed.

Comment 8 errata-xmlrpc 2020-11-04 02:01:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (kmod-kvdo bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4551