Bug 1805334
| Summary: | vhost-user/50-qemu-gpu.json is not valid JSON | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | Ján Tomko <jtomko> |
| Component: | qemu-kvm | Assignee: | Ján Tomko <jtomko> |
| qemu-kvm sub component: | General | QA Contact: | Guo, Zhiyi <zhguo> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | medium | ||
| Priority: | unspecified | CC: | coli, jinzhao, juzhang, kraxel, virt-maint |
| Version: | 8.2 | ||
| Target Milestone: | rc | ||
| Target Release: | 8.2 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | qemu-kvm-4.2.0-12.module+el8.2.0+5858+afd073bc | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-05 09:57:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1805324 | ||
Hi Gerd, I think the 50-qemu-gpu.json is part of using virgl with vhost-user, right? Is this vhost-user-gpu already testable on rhel 8.2? I don't see any RFE bugs point to the support to vhost-user-gpu, what's the plan to support vhost-user-gpu? Thanks! BR/ Zhiyi Zhiyi, my motivation is virtiofsd. To find out which vhost-user binary offers "type": "fs", libvirt needs to parse all the vhost-user json files, which it cannot if they aren't valid. Verify this issue against qemu-kvm-core-4.2.0-12.module+el8.2.0+5858+afd073bc.x86_64
# cat /usr/share/qemu-kvm/vhost-user/50-qemu-gpu.json | jq
{
"description": "QEMU vhost-user-gpu",
"type": "gpu",
"binary": "/usr/libexec/vhost-user-gpu"
}
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2017 |
Description of problem: Trailing comma is not valid json: $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq parse error: Expected another key-value pair at line 5, column 1 Version-Release number of selected component (if applicable): qemu-kvm-core-4.2.0-1.module+el8.2.0+4793+b09dd2fb.x86_64 How reproducible: 0144 % Additional info: Fixed upstream by: commit ca26b032e5a0e8a190c763ce828a8740d24b9b65 Author: Cole Robinson <crobinso> CommitDate: 2019-12-20 06:56:37 +0100 vhost-user-gpu: Drop trailing json comma Trailing comma is not valid json: $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq parse error: Expected another key-value pair at line 5, column 1 Signed-off-by: Cole Robinson <crobinso> Reviewed-by: Marc-André Lureau <marcandre.lureau> Reviewed-by: Li Qiang <liq3ea> Reviewed-by: Philippe Mathieu-Daudé <philmd> Message-id: 7f5dd2ac9f3504e2699f23e69bc3d8051b729832.1568925097.git.crobinso Signed-off-by: Gerd Hoffmann <kraxel> git describe: v4.2.0-199-gca26b032e5