Bug 1805451
| Summary: | After upgrading from CloudForms 4.5 to 5.11 provisioning is no longer working correctly | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Ryan Spagnola <rspagnol> |
| Component: | Automate | Assignee: | Tina Fitzgerald <tfitzger> |
| Status: | CLOSED ERRATA | QA Contact: | Jaroslav Henner <jhenner> |
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
| Priority: | unspecified | ||
| Version: | 5.11.0 | CC: | dmetzger, duhlmann, gmccullo, jhenner, jrafanie, mkanoor, nansari, obarenbo, simaishi, tfitzger, tuado |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.11.5 | Flags: | pm-rhel:
cfme-5.11.z+
rspagnol: needinfo- mfeifer: mirror+ |
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | 5.11.5.0 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-05 13:43:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | Bug | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | CFME Core | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ryan Spagnola
2020-02-20 19:59:04 UTC
We noticed a delete_service being called shortly before the can't modify frozen hash in the task_finished part of the service provisioning. It's unclear if this is a "safe" time to delete the service as anything that happens after the service is deleted could either have stale in-memory data or we attempt to update a frozen record. New commit detected on ManageIQ/manageiq-automation_engine/ivanchuk: https://github.com/ManageIQ/manageiq-automation_engine/commit/fb2fb61f4a9b1cdf6d3afc65abe9ac0276a0e272 commit fb2fb61f4a9b1cdf6d3afc65abe9ac0276a0e272 Author: tina <tfitzger> AuthorDate: Wed Mar 4 19:48:15 2020 +0000 Commit: tina <tfitzger> CommitDate: Wed Mar 4 19:48:15 2020 +0000 Merge pull request #429 from d-m-u/removing_to_xml Remove the to_xml call from miq_ae_engine (cherry picked from commit 1a3ba3a3cde0706890050e405f56b4c808213c1e) https://bugzilla.redhat.com/show_bug.cgi?id=1805451 lib/miq_automation_engine/engine/miq_ae_engine.rb | 4 +- 1 file changed, 1 insertion(+), 3 deletions(-) New commit detected on ManageIQ/manageiq-automation_engine/jansa: https://github.com/ManageIQ/manageiq-automation_engine/commit/36885d034e765652b16216e7e143fe63e94279ed commit 36885d034e765652b16216e7e143fe63e94279ed Author: tina <tfitzger> AuthorDate: Wed Mar 4 19:48:15 2020 +0000 Commit: tina <tfitzger> CommitDate: Wed Mar 4 19:48:15 2020 +0000 Merge pull request #429 from d-m-u/removing_to_xml Remove the to_xml call from miq_ae_engine (cherry picked from commit 1a3ba3a3cde0706890050e405f56b4c808213c1e) https://bugzilla.redhat.com/show_bug.cgi?id=1805451 lib/miq_automation_engine/engine/miq_ae_engine.rb | 4 +- 1 file changed, 1 insertion(+), 3 deletions(-) @Tina Is there some way I could reproduce this? If not, I think I will need the customer DB as well. I understood that serialisation to xml in some debug calls failed, but I also am not much sure what was the root cause. @Ryan, could you help me to reproduce this? Hi Jaroslav, Since we're removing the to_xml code, we just need to validate that removing the to_xml call doesn't cause problems. Can you test provisioning with/without DEBUG logging on for Automate as follows: 1. Turn on DEBUG for Automate in Advanced settings. 2. Perform a VM lifecycle provision and check logs for xml dump. 3. Check for errors. Let me know if you have any questions. Thanks, Tina I was not able to reproduce the issue with the info I got. I think to reproduce I need some funky string stored in database that makes problems when serializing. So only thing I did check is that some debug log lines were removed. Indeed, when I provision and retire a VM, on CFME version prior the fixed-in-version I got: [root@dhcp-8-198-205 ~]# grep DEBUG /var/www/miq/vmdb/log/* grep: /var/www/miq/vmdb/log/apache: Is a directory /var/www/miq/vmdb/log/automation.log:[----] D, [2020-04-27T07:49:27.955806 #7324:2b0de6b85dd4] DEBUG -- : <MiqAeWorkspace> /var/www/miq/vmdb/log/automation.log:[----] D, [2020-04-27T07:49:28.777145 #7324:2b0de6b85dd4] DEBUG -- : <MiqAeWorkspace> ... while on the later version I got no debug statements in the automation log even though I've set this advanced config on both: :log: :level_automation: debug Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2020 |