Bug 1805681

Summary: Review Request: catharsis-cormorant-fonts - A display serif font family inspired by the Garamond heritage
Product: [Fedora] Fedora Reporter: Nicolas Mailhot <nicolas.mailhot>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fonts-bugs, package-review, panemade
Target Milestone: ---Flags: panemade: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-31 00:16:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 11:20:52 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240806-catharsis-cormorant-fonts/catharsis-cormorant-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240806-catharsis-cormorant-fonts/catharsis-cormorant-fonts-3.602-1.20191209git83d1fa9.fc33.src.rpm

Description:
Cormorant is an original design for an extravagant display serif font family
inspired by the Garamond heritage, hand-drawn and produced by Catharsis Fonts.
While traditional Garamond cuts make for exquisite reading at book sizes, they
appear clumpy and inelegant at larger sizes. The design goal of Cormorant was
to distill the æsthetic essence of Garamond, unfetter it from the limitations
of metal printing, and allow it to bloom into its natural refined form at high
definition.

Fedora Account System Username: nim


One of the top font families on Google fonts.

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 2 Parag AN(पराग) 2020-03-15 10:28:06 UTC
Review:

This package follows new fonts packaging guidelines.

Rpmlint
-------
catharsis-cormorant-fonts.noarch: W: spelling-error %description -l en_US kerning -> keening, kenning, tinkering
catharsis-cormorant-fonts.noarch: W: incoherent-version-in-changelog 3.602-2 ['3.602-2.20191209git83d1fa9.fc33', '3.602-2.20191209git83d1fa9']
catharsis-cormorant-fonts.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-fonts.src: W: spelling-error %description -l en_US kerning -> keening, kenning, tinkering
catharsis-cormorant-fonts.src: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-fonts-all.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-fonts-all.noarch: W: no-documentation
catharsis-cormorant-fonts-doc.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-garamond-fonts.noarch: W: spelling-error %description -l en_US kerning -> keening, kenning, tinkering
catharsis-cormorant-garamond-fonts.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-infant-fonts.noarch: W: spelling-error %description -l en_US kerning -> keening, kenning, tinkering
catharsis-cormorant-infant-fonts.noarch: W: spelling-error %description -l en_US storey -> store, story, stores
catharsis-cormorant-infant-fonts.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-unicase-fonts.noarch: W: spelling-error %description -l en_US kerning -> keening, kenning, tinkering
catharsis-cormorant-unicase-fonts.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
catharsis-cormorant-upright-fonts.noarch: W: spelling-error Summary(en_US) un -> UN, nu, in
catharsis-cormorant-upright-fonts.noarch: W: spelling-error %description -l en_US kerning -> keening, kenning, tinkering
catharsis-cormorant-upright-fonts.noarch: W: spelling-error %description -l en_US un -> UN, nu, in
catharsis-cormorant-upright-fonts.noarch: W: invalid-url URL: https://www.behance.net/gallery/28579883/Cormorant-an-open-source-display-font-family HTTP Error 404: Not Found
8 packages and 0 specfiles checked; 0 errors, 19 warnings.


Source checksums
----------------
https://github.com/CatharsisFonts/Cormorant/archive/83d1fa9b582005f8f913d178fdbe98094698a6c4/Cormorant-83d1fa9b582005f8f913d178fdbe98094698a6c4.tar.gz :
  CHECKSUM(SHA256) this package     : 1815f47f66fa88de6aed2d181a9d0e065141001c43dbf38a4562c5fb75485a9f
  CHECKSUM(SHA256) upstream package : 1815f47f66fa88de6aed2d181a9d0e065141001c43dbf38a4562c5fb75485a9f


subpackaging looks good.

Issues:
1) Fix the Changelog rpmlint warning before import of this package.

APPROVED.

Comment 3 Nicolas Mailhot 2020-03-15 10:45:45 UTC
> Issues:
> 1) Fix the Changelog rpmlint warning before import of this package.

The changelog will be correct as long as I remember to import the original SRPM, not one round-tripped through copr (copr does not preserve timestamps like koji does, halas, another bug to report) :(

Comment 4 Gwyn Ciesla 2020-03-16 13:38:26 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/catharsis-cormorant-fonts

Comment 5 Fedora Update System 2020-03-16 16:11:18 UTC
FEDORA-2020-5f8c473ae4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5f8c473ae4

Comment 6 Fedora Update System 2020-03-16 16:11:30 UTC
FEDORA-2020-195c99533a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-195c99533a

Comment 7 Fedora Update System 2020-03-17 01:45:57 UTC
catharsis-cormorant-fonts-3.602-2.20200316git83d1fa9.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5f8c473ae4

Comment 8 Fedora Update System 2020-03-17 02:49:02 UTC
catharsis-cormorant-fonts-3.602-2.20200316git83d1fa9.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-195c99533a

Comment 9 Fedora Update System 2020-03-31 00:16:12 UTC
FEDORA-2020-195c99533a has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.