Bug 1805691

Summary:	Review Request: gfs-galatea-fonts - A 20th century Greek font family
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-24 22:57:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 11:40:24 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240820-gfs-galatea-fonts/gfs-galatea-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240820-gfs-galatea-fonts/gfs-galatea-fonts-20191205-1.fc33.src.rpm

Description:
GFS Galatea Bold revives in digital form an older hot metal typeface from the
1920’s, which can be found in older Greek type specimens named simply as FAT
type. The font was used as a bold companion of Didot Greek (Apla/Monotype 92).
It has many similarities with Didot Greek (Απλά) in design, but it differs in
its reduced stroke contrast, the use of a lunar lower case epsilon (reminiscent
of the similar epsilon in Porson Greek) and in sturdier stems and slab serifs.
An experimental projection of these characteristics to a lighter version has
led to the introduction of GFS Galatea Regular. The name Galatea is a tribute
to the author and feminist Galatea Kazantzakis (1881–1962) as samples of the
typeface were found in several of her books.

Fedora Account System Username: nim



Another GFS font family, to bring the GFS catalog in Fedora to 100%


The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-24 12:34:21 UTC

Review:

This package follows new fonts packaging guidelines.


Rpmlint
-------
Checking: gfs-galatea-fonts-20191205-1.fc33.noarch.rpm
          gfs-galatea-fonts-doc-20191205-1.fc33.noarch.rpm
          gfs-galatea-fonts-20191205-1.fc33.src.rpm
gfs-galatea-fonts-doc.noarch: W: summary-not-capitalized C gfs-galatea-fonts optional documentation files
gfs-galatea-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with gfs-galatea-fonts.
gfs-galatea-fonts-doc.noarch: E: non-readable /usr/share/doc/gfs-galatea-fonts-doc/GFS_Galatea_Specimen.pdf 640
3 packages and 0 specfiles checked; 2 errors, 1 warnings.


Source checksums
----------------
http://www.greekfontsociety-gfs.gr/_assets/fonts/GFS_Galatea.zip :
  CHECKSUM(SHA256) this package     : b20cbf4ff704f0741a9b89376e5c497392b23282eebacbfdab2502a861f16ac2
  CHECKSUM(SHA256) upstream package : b20cbf4ff704f0741a9b89376e5c497392b23282eebacbfdab2502a861f16ac2


Requires
--------
gfs-galatea-fonts (rpmlib, GLIBC filtered):
    config(gfs-galatea-fonts)
    fontpackages-filesystem

gfs-galatea-fonts-doc (rpmlib, GLIBC filtered):



Provides
--------
gfs-galatea-fonts:
    config(gfs-galatea-fonts)
    font(gfsgalatea)
    gfs-galatea-fonts
    metainfo()
    metainfo(org.fedoraproject.gfs-galatea-fonts.metainfo.xml)

gfs-galatea-fonts-doc:
    gfs-galatea-fonts-doc


All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warnings/errors before this package import

APPROVED

Comment 2 Nicolas Mailhot 2020-02-24 20:39:02 UTC

Fixed, the warnings (same sed as other spec files), thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22488

Comment 3 Gwyn Ciesla 2020-02-24 20:49:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gfs-galatea-fonts

Comment 4 Nicolas Mailhot 2020-02-24 22:57:46 UTC

And this one is done for F32 & F33. Thanks all who contributed.