Bug 1805698

Summary:	Review Request: gfs-neohellenic-math-fonts - An almost Sans Serif Math font family
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-24 23:32:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 11:58:21 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240829-gfs-neohellenic-math-fonts/gfs-neohellenic-math-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240829-gfs-neohellenic-math-fonts/gfs-neohellenic-math-fonts-20180227-1.fc33.src.rpm

Description:

GFS NeoHellenic Math is an almost Sans Serif font family. One of its main uses
is for presentations, an area where (we believe) a commercial grade sans math
font was not available up to now.

The font family contains an extened glyph set including more than the standard
math symbols such as vertically extended integrals, chess symbols, etc.

It was commissioned to the Greek Font Society (GFS) by the Graduate Studies
program “Studies in Mathematics” of the Department of Mathematics of the
University of the Aegean, located on the Samos island, Greece.

The design copyright belongs to the main designer of GFS, George Matthiopoulos.
The OpenType Math Table embedded in the font was developed by the Mathematics
Professor Antonis Tsolomitis.

Fedora Account System Username: nim



Another GFS font family, to bring the GFS catalog in Fedora to 100%


The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-24 12:34:06 UTC

Review:

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: gfs-neohellenic-math-fonts-20180227-1.fc33.noarch.rpm
          gfs-neohellenic-math-fonts-doc-20180227-1.fc33.noarch.rpm
          gfs-neohellenic-math-fonts-20180227-1.fc33.src.rpm
gfs-neohellenic-math-fonts.noarch: W: spelling-error %description -l en_US extened -> extend, extended, extenuated
gfs-neohellenic-math-fonts-doc.noarch: W: summary-not-capitalized C gfs-neohellenic-math-fonts optional documentation files
gfs-neohellenic-math-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with gfs-neohellenic-math-fonts.
gfs-neohellenic-math-fonts.src: W: spelling-error %description -l en_US extened -> extend, extended, extenuated
3 packages and 0 specfiles checked; 1 errors, 3 warnings.


Source checksums
----------------
http://www.greekfontsociety-gfs.gr/_assets/fonts/GFS_NeoHellenic_Math.zip :
  CHECKSUM(SHA256) this package     : 03b301ad47e918677a6c5130783fbd66acaf0b69864fb531215c82f6fcbc4e0f
  CHECKSUM(SHA256) upstream package : 03b301ad47e918677a6c5130783fbd66acaf0b69864fb531215c82f6fcbc4e0f


Requires
--------
gfs-neohellenic-math-fonts (rpmlib, GLIBC filtered):
    config(gfs-neohellenic-math-fonts)
    fontpackages-filesystem
    gfs-neohellenic-fonts

gfs-neohellenic-math-fonts-doc (rpmlib, GLIBC filtered):



Provides
--------
gfs-neohellenic-math-fonts:
    config(gfs-neohellenic-math-fonts)
    font(gfsneohellenicmath)
    gfs-neohellenic-math-fonts
    metainfo()
    metainfo(org.fedoraproject.gfs-neohellenic-math-fonts.metainfo.xml)

gfs-neohellenic-math-fonts-doc:
    gfs-neohellenic-math-fonts-doc




All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warnings/errors before this package import

APPROVED

Comment 2 Nicolas Mailhot 2020-02-24 20:34:01 UTC

Fixed the warnings, thanks for another great review!

https://pagure.io/releng/fedora-scm-requests/issue/22486

Comment 3 Gwyn Ciesla 2020-02-24 20:48:46 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gfs-neohellenic-math-fonts

Comment 4 Nicolas Mailhot 2020-02-24 23:31:48 UTC

Done for F32 & F33. Thanks Parag and Gwyn.