Bug 1805725

Summary:	Review Request: gfs-orpheus-fonts - A 21st century Greek font family
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-24 23:04:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 12:46:44 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240833-gfs-orpheus-fonts/gfs-orpheus-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240833-gfs-orpheus-fonts/gfs-orpheus-fonts-20161102-1.fc33.src.rpm

Description:
GFS Orpheus is a variation of GFS Orpheus Classic. It was based on the text
found in a school textbook entitled Στοιχειώδης Φυσική Ιστορία, published by
the publisher Anestis Konstantinidis in Athens on 1887. The x-height is shorter
(longer descenders), while the uppercase characters and the numbers were
designed from scratch, following more closely the style of the lowercase
characters.

GFS Orpheus was designed by George Triantafyllakos.

Fedora Account System Username: nim



Another GFS font family, to bring the GFS catalog in Fedora to 100%


The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-24 12:33:44 UTC

Review:

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: gfs-orpheus-fonts-20161102-1.fc33.noarch.rpm
          gfs-orpheus-fonts-doc-20161102-1.fc33.noarch.rpm
          gfs-orpheus-fonts-20161102-1.fc33.src.rpm
gfs-orpheus-fonts.noarch: W: spelling-error %description -l en_US descenders -> descender, descender s, descends
gfs-orpheus-fonts-doc.noarch: W: summary-not-capitalized C gfs-orpheus-fonts optional documentation files
gfs-orpheus-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with gfs-orpheus-fonts.
gfs-orpheus-fonts-doc.noarch: E: non-readable /usr/share/doc/gfs-orpheus-fonts-doc/GFS_Orpheus_Specimen.pdf 640
gfs-orpheus-fonts.src: W: spelling-error %description -l en_US descenders -> descender, descender s, descends
3 packages and 0 specfiles checked; 2 errors, 3 warnings.

Source checksums
----------------
http://www.greekfontsociety-gfs.gr/_assets/fonts/GFS_Orpheus.zip :
  CHECKSUM(SHA256) this package     : 7bfe591a3d31d13edfe82f6ba968ad1b0fcd2ee5ecb579b9837181949679752c
  CHECKSUM(SHA256) upstream package : 7bfe591a3d31d13edfe82f6ba968ad1b0fcd2ee5ecb579b9837181949679752c


Requires
--------
gfs-orpheus-fonts (rpmlib, GLIBC filtered):
    config(gfs-orpheus-fonts)
    fontpackages-filesystem

gfs-orpheus-fonts-doc (rpmlib, GLIBC filtered):



Provides
--------
gfs-orpheus-fonts:
    config(gfs-orpheus-fonts)
    font(gfsorpheus)
    gfs-orpheus-fonts
    metainfo()
    metainfo(org.fedoraproject.gfs-orpheus-fonts.metainfo.xml)

gfs-orpheus-fonts-doc:
    gfs-orpheus-fonts-doc


All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warnings/errors before this package import

APPROVED

Comment 2 Nicolas Mailhot 2020-02-24 20:18:47 UTC

Fixed everything except the font tech speak.

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22482

Comment 3 Gwyn Ciesla 2020-02-24 20:47:35 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gfs-orpheus-fonts

Comment 4 Nicolas Mailhot 2020-02-24 23:04:56 UTC

Done for F32 & F33. Thanks Parag and Gwyn.