Bug 1805738

Summary:	Review Request: ht-alegreya-sans-fonts - A humanist sans serif font family with a calligraphic feeling
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-26 20:16:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 13:20:16 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240844-ht-alegreya-sans-fonts/ht-alegreya-sans-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240844-ht-alegreya-sans-fonts/ht-alegreya-sans-fonts-2.008-1.fc33.src.rpm

Description:
Alegreya Sans is a humanist sans serif font family with a calligraphic feeling
that conveys a dynamic and varied rhythm. This gives a pleasant feeling to
readers of long texts.

The family follows humanist proportions and principles, just like the serif
version of the family, Alegreya. It achieves a ludic and harmonious paragraph
through elements carefully designed in an atmosphere of diversity.

Fedora Account System Username: nim



One of the top font families on Google fonts.

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-26 09:16:32 UTC

Review:

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: ht-alegreya-sans-fonts-2.008-1.fc33.noarch.rpm
          ht-alegreya-sans-fonts-2.008-1.fc33.src.rpm
ht-alegreya-sans-fonts.noarch: W: spelling-error %description -l en_US ludic -> lucid, ludicrous
ht-alegreya-sans-fonts.noarch: W: spurious-executable-perm /usr/share/doc/ht-alegreya-sans-fonts/OFL.txt
ht-alegreya-sans-fonts.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/ht-alegreya-sans-fonts/OFL.txt
ht-alegreya-sans-fonts.src: W: spelling-error %description -l en_US ludic -> lucid, ludicrous
2 packages and 0 specfiles checked; 1 errors, 3 warnings.

Source checksums
----------------
https://github.com/huertatipografica/Alegreya-Sans/archive/v2.008/Alegreya-Sans-2.008.tar.gz :
  CHECKSUM(SHA256) this package     : ea545572d49e18e675d6b72a6754da344e24b9cacc3d2b76c1eb2bf9ae73a402
  CHECKSUM(SHA256) upstream package : ea545572d49e18e675d6b72a6754da344e24b9cacc3d2b76c1eb2bf9ae73a402


Requires
--------
ht-alegreya-sans-fonts (rpmlib, GLIBC filtered):
    config(ht-alegreya-sans-fonts)
    fontpackages-filesystem



Provides
--------
ht-alegreya-sans-fonts:
    config(ht-alegreya-sans-fonts)
    font(alegreyasans)
    font(alegreyasansblack)
    font(alegreyasansextrabold)
    font(alegreyasanslight)
    font(alegreyasansmedium)
    font(alegreyasansthin)
    ht-alegreya-sans-fonts
    metainfo()
    metainfo(org.fedoraproject.ht-alegreya-sans-fonts.metainfo.xml)


All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warnings/errors before import of this package
2) I looked for %license in this package spec but cannot find it. Shouldn't we need to mark some file say OFL.txt as %license?
I see in other packages when you create -doc subpackage %license gets marked automatically.

APPROVED.

Comment 2 Nicolas Mailhot 2020-02-26 19:10:10 UTC

https://pagure.io/releng/fedora-scm-requests/issue/22553

Comment 3 Gwyn Ciesla 2020-02-26 19:32:30 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ht-alegreya-sans-fonts

Comment 4 Nicolas Mailhot 2020-02-26 20:16:32 UTC

Built for F32 (update) and F33

Thanks Parag and Gwyn