Bug 1805820

Summary:	gdeploy fails to build with Python 3.9: invalid version in specfile
Product:	[Fedora] Fedora	Reporter:	Marcel Plch <mplch>
Component:	gdeploy	Assignee:	Prajith <pkesavap>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	cstratak, godas, mhroncok, mplch, pkesavap, ramkrsna, sacchi
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	gdeploy-3.0.0-7.20200525git05d894b.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-17 09:25:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1785415, 1803234

Description Marcel Plch 2020-02-21 15:28:06 UTC

gdeploy fails to build with Python 3.9.0a3.

We are trying to rebuild all Python packages in COPR with Python 3.9, however, this package fails as there is no v3.0.0 available upstream:

[mplch@redpad gdeploy]$ spectool -g $(fedpkg gimmespec)
Getting https://github.com/gluster/gdeploy/archive/v3.0.0.tar.gz#/gdeploy-3.0.0-6.fc31.tar.gz to ./gdeploy-3.0.0-6.fc31.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   123    0   123    0     0    504      0 --:--:-- --:--:-- --:--:--   504
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

---

There is also no 3.0.0-6 in the lookaside cache:

$ vim gdeploy.spec

  5 Name:           gdeploy
  6 Version:        3.0.0
  7 Release:        6%{?dist}

$ fedpkg mockbuild

Downloading gdeploy-3.0.0-4.tar.gz
######################################################################## 100.0%
warning: Macro expanded in comment on line 93: %{_unitdir}/vdo.service

error: Bad source: /home/mplch/Work/fedpkg/gdeploy/gdeploy-3.0.0-6.fc33.tar.gz: No such file or directory
Could not execute mockbuild: Failed to execute command.

---

May I ask how to proceed to successfully rebuild this package?


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01248166-gdeploy/

For all our attempts to build gdeploy with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/gdeploy/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Prajith 2020-02-22 10:20:03 UTC

Hi,

Im looking into this, usually the "error: Bad source" comes if the tar file is not properly given the name as defined in spec file.
Taking a single look is the expected name "gdeploy-3.0.0-6.fc33.tar.gz" rather than fc32? since im seeing that is a mass build for fedora 32 as mentioned in the change log.

Comment 2 Marcel Plch 2020-02-24 10:29:38 UTC

Hi,

IMHO, I don't think the tarball name should contain Fedora version at all, that should be just the upstream sources version.

Comment 3 Prajith 2020-02-24 10:39:06 UTC

(In reply to Marcel Plch from comment #2)
> Hi,
> 
> IMHO, I don't think the tarball name should contain Fedora version at all,
> that should be just the upstream sources version.

yes correct!,

Comment 4 Miro Hrončok 2020-05-25 13:01:25 UTC

This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 5 Charalampos Stratakis 2020-05-25 16:27:24 UTC

PR: https://src.fedoraproject.org/rpms/gdeploy/pull-request/3#

Comment 6 Miro Hrončok 2020-05-29 07:11:27 UTC

Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.