Bug 1806003

Summary:	Review Request: vernnobile-muli-fonts - A minimalist sans serif font family
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-25 21:25:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 20:01:54 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240889-vernnobile-muli-fonts/vernnobile-muli-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240889-vernnobile-muli-fonts/vernnobile-muli-fonts-2.001-1.20191208git580b05e.fc33.src.rpm

Description:
Muli is a minimalist sans serif font family, designed for both display and text
typography.

Fedora Account System Username: nim



One of the top font families on Google fonts.

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-25 17:02:15 UTC

Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: vernnobile-muli-fonts-2.001-1.20191208git580b05e.fc33.noarch.rpm
          vernnobile-muli-fonts-2.001-1.20191208git580b05e.fc33.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Source checksums
----------------
https://github.com/googlefonts/MuliFont/archive/580b05e1f2ad319cd98a8de03fd2da7b36677954/MuliFont-580b05e1f2ad319cd98a8de03fd2da7b36677954.tar.gz :
  CHECKSUM(SHA256) this package     : d6e302974bd518ff215cb0112d576b11afb44847e28559700e434bf01e353449
  CHECKSUM(SHA256) upstream package : d6e302974bd518ff215cb0112d576b11afb44847e28559700e434bf01e353449


Requires
--------
vernnobile-muli-fonts (rpmlib, GLIBC filtered):
    config(vernnobile-muli-fonts)
    fontpackages-filesystem



Provides
--------
vernnobile-muli-fonts:
    config(vernnobile-muli-fonts)
    font(muli)
    font(muliblack)
    font(muliextrabold)
    font(muliextralight)
    font(mulilight)
    font(mulisemibold)
    metainfo()
    metainfo(org.fedoraproject.vernnobile-muli-fonts.metainfo.xml)
    vernnobile-muli-fonts


All other things like license, config, metainfo files looks good.

APPROVED.

Comment 2 Nicolas Mailhot 2020-02-25 20:33:15 UTC

Yahoo, nothing to fix, thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/22534

Comment 3 Gwyn Ciesla 2020-02-25 21:08:14 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/vernnobile-muli-fonts

Comment 4 Nicolas Mailhot 2020-02-25 21:25:20 UTC

Built for F32 (update) and F33

Thanks Parag and Gwyn