Bug 1806021

Summary:	Review Request: wagesreiter-patrick-hand-fonts - An handwriting font family
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-25 20:52:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 20:15:57 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240893-wagesreiter-patrick-hand-fonts/wagesreiter-patrick-hand-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240893-wagesreiter-patrick-hand-fonts/wagesreiter-patrick-hand-fonts-20200215-1.fc33.src.rpm

Description:
Patrick Hand is a font family based on the designer’s own handwriting. It is
developed to bring an impressive and useful handwriting effect to your
texts.

It has all the basic latin characters as well as most of the latin extended
ones. It also includes some fancy glyphs like heavy quotation marks and the
floral heart! Ligatures, small caps and old style numbers are available as
OpenType features.

Fedora Account System Username: nim



A font family used by Microsoft PowerApps

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Nicolas Mailhot 2020-02-21 20:21:57 UTC

Correction: this spec is an exception among Google fonts, it does not use forge automation

Comment 2 Parag AN(पराग) 2020-02-25 17:02:36 UTC

Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: wagesreiter-patrick-hand-fonts-20200215-1.fc33.noarch.rpm
          wagesreiter-patrick-hand-fonts-20200215-1.fc33.src.rpm
wagesreiter-patrick-hand-fonts.noarch: W: spelling-error %description -l en_US latin -> Latin, lain, satin
wagesreiter-patrick-hand-fonts.noarch: W: incoherent-version-in-changelog 20191208-1 ['20200215-1.fc33', '20200215-1']
wagesreiter-patrick-hand-fonts.noarch: W: unexpanded-macro URL %{forgeurl}
wagesreiter-patrick-hand-fonts.noarch: W: invalid-url URL %{forgeurl}
wagesreiter-patrick-hand-fonts.src: W: spelling-error %description -l en_US latin -> Latin, lain, satin
wagesreiter-patrick-hand-fonts.src: W: unexpanded-macro URL %{forgeurl}
wagesreiter-patrick-hand-fonts.src: W: invalid-url URL %{forgeurl}
wagesreiter-patrick-hand-fonts.src: W: strange-permission getfiles.sh 775
wagesreiter-patrick-hand-fonts.src: W: invalid-url Source0: wagesreiter-patrick-hand-fonts-20200215.tar.xz
2 packages and 0 specfiles checked; 0 errors, 9 warnings.




Requires
--------
wagesreiter-patrick-hand-fonts (rpmlib, GLIBC filtered):
    config(wagesreiter-patrick-hand-fonts)
    fontpackages-filesystem



Provides
--------
wagesreiter-patrick-hand-fonts:
    config(wagesreiter-patrick-hand-fonts)
    font(patrickhand)
    metainfo()
    metainfo(org.fedoraproject.wagesreiter-patrick-hand-fonts.metainfo.xml)
    wagesreiter-patrick-hand-fonts


All other things like license, config, metainfo files looks good.

Issues:
1) Fix the rpmlint warnings/errors before import of this package.

APPROVED.

Comment 3 Nicolas Mailhot 2020-02-25 20:13:09 UTC

https://pagure.io/releng/fedora-scm-requests/issue/22527

Comment 4 Gwyn Ciesla 2020-02-25 20:30:43 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/wagesreiter-patrick-hand-fonts

Comment 5 Nicolas Mailhot 2020-02-25 20:52:57 UTC

Built for F32 (update) and F33

Thanks Parag and Gwyn