Bug 1806024

Summary:	Review Request: weiweihuanghuang-work-sans-fonts - A font family in the early grotesque style
Product:	[Fedora] Fedora	Reporter:	Nicolas Mailhot <nicolas.mailhot>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-26 18:52:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nicolas Mailhot 2020-02-21 20:20:01 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240894-weiweihuanghuang-work-sans-fonts/weiweihuanghuang-work-sans-fonts.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedora-rawhide-x86_64/01240894-weiweihuanghuang-work-sans-fonts/weiweihuanghuang-work-sans-fonts-2.07-1.20191208gitdcd044c.fc33.src.rpm

Description:
Work Sans is a font family based loosely on early Grotesques — i.e. Stephenson
Blake, Miller & Richard and Bauerschen Giesserei. The core of the fonts are
optimised for on-screen medium-sized text usage,  but can still be used in
print. The fonts at the extreme weights are designed more for display use.
Overall, features are simplified and optimised for screen resolutions – for
example, diacritic marks are larger than how they would be in print.
Fedora Account System Username: nim




One of the top font families on Google fonts.

The packaging conforms to https://pagure.io/packaging-committee/issue/935
as approved by FPC on 2020-02-13.

It makes use of our forge automation:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

It is one of the test packages that were used to refine the new packaging guidelines
https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/

The new fonts packaging build chain is now live in koji. For example:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243

If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25)
https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html

Comment 1 Parag AN(पराग) 2020-02-25 17:02:43 UTC

Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: weiweihuanghuang-work-sans-fonts-2.07-1.20191208gitdcd044c.fc33.noarch.rpm
          weiweihuanghuang-work-sans-fonts-doc-2.07-1.20191208gitdcd044c.fc33.noarch.rpm
          weiweihuanghuang-work-sans-fonts-2.07-1.20191208gitdcd044c.fc33.src.rpm
weiweihuanghuang-work-sans-fonts.noarch: W: spelling-error %description -l en_US optimised -> optimized, optimist, optimism
weiweihuanghuang-work-sans-fonts.noarch: W: spurious-executable-perm /usr/share/doc/weiweihuanghuang-work-sans-fonts/AUTHORS.txt
weiweihuanghuang-work-sans-fonts.noarch: W: spurious-executable-perm /usr/share/doc/weiweihuanghuang-work-sans-fonts/BUILD.md
weiweihuanghuang-work-sans-fonts.noarch: W: spurious-executable-perm /usr/share/doc/weiweihuanghuang-work-sans-fonts/CONTRIBUTORS.txt
weiweihuanghuang-work-sans-fonts.noarch: W: spurious-executable-perm /usr/share/doc/weiweihuanghuang-work-sans-fonts/README.md
weiweihuanghuang-work-sans-fonts-doc.noarch: W: summary-not-capitalized C weiweihuanghuang-work-sans-fonts optional documentation files
weiweihuanghuang-work-sans-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with weiweihuanghuang-work-sans-fonts.
weiweihuanghuang-work-sans-fonts-doc.noarch: W: spurious-executable-perm /usr/share/doc/weiweihuanghuang-work-sans-fonts-doc/DESCRIPTION.en_us.html
weiweihuanghuang-work-sans-fonts.src: W: spelling-error %description -l en_US optimised -> optimized, optimist, optimism
3 packages and 0 specfiles checked; 1 errors, 8 warnings.


Source checksums
----------------
https://github.com/weiweihuanghuang/Work-Sans/archive/dcd044c29b6f92f101a94777f744fa0f051da14b/Work-Sans-dcd044c29b6f92f101a94777f744fa0f051da14b.tar.gz :
  CHECKSUM(SHA256) this package     : 9edc9d0ce7416de04b453f95524b23aa6783d713921e7df2ec1c2442cb65d4ff
  CHECKSUM(SHA256) upstream package : 9edc9d0ce7416de04b453f95524b23aa6783d713921e7df2ec1c2442cb65d4ff


Requires
--------
weiweihuanghuang-work-sans-fonts (rpmlib, GLIBC filtered):
    config(weiweihuanghuang-work-sans-fonts)
    fontpackages-filesystem

weiweihuanghuang-work-sans-fonts-doc (rpmlib, GLIBC filtered):



Provides
--------
weiweihuanghuang-work-sans-fonts:
    config(weiweihuanghuang-work-sans-fonts)
    font(worksans)
    font(worksansblack)
    font(worksansextrabold)
    font(worksansextralight)
    font(worksanslight)
    font(worksansmedium)
    font(worksanssemibold)
    font(worksansthin)
    metainfo()
    metainfo(org.fedoraproject.weiweihuanghuang-work-sans-fonts.metainfo.xml)
    weiweihuanghuang-work-sans-fonts

weiweihuanghuang-work-sans-fonts-doc:
    weiweihuanghuang-work-sans-fonts-doc


All other things like license, config, metainfo files looks good.


Issues:
1) Fix the rpmlint warnings/errors before import of this package.

APPROVED.

Comment 2 Nicolas Mailhot 2020-02-25 19:58:09 UTC

Hi Parag,

I fixed the spelling but you forgot to set fedora-review+ :)

Comment 3 Parag AN(पराग) 2020-02-26 03:02:09 UTC

Sorry I missed that in a hurry before closing my work for the day :)

It is set now.

Comment 4 Nicolas Mailhot 2020-02-26 07:18:55 UTC

https://pagure.io/releng/fedora-scm-requests/issue/22538

Comment 5 Gwyn Ciesla 2020-02-26 15:11:57 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/weiweihuanghuang-work-sans-fonts

Comment 6 Nicolas Mailhot 2020-02-26 18:52:03 UTC

Built for F32 (update) and F33

Thanks Parag and Gwyn