Bug 1806241 (php-webimpress-safe-writer)

Summary: Review Request: php-webimpress-safe-writer - Tool to write files safely, to avoid race conditions
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-23 02:37:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpci.log
none
review.txt none

Description Shawn Iwinski 2020-02-23 07:35:16 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/eb89d68d91e385d46974bcb83de75ce0bf274d47/php-webimpress-safe-writer/php-webimpress-safe-writer.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-webimpress-safe-writer-2.0.0-1.fc31.src.rpm

Description:
Write files safely to avoid race conditions when the same file is written
multiple times in a short time period.

Fedora Account System Username: siwinski
Comment 1 Remi Collet 2020-02-27 08:34:31 UTC 
Created attachment 1666147 [details]
phpci.log
Comment 2 Remi Collet 2020-02-27 08:34:58 UTC 
Created attachment 1666148 [details]
review.txt
Comment 3 Remi Collet 2020-02-27 08:36:36 UTC 
Minor: as this package requires PHP 7.2 and use phpunit8, please drop 7.0 and 7.1 from the test loop


[x]: Package complies to the Packaging Guidelines


No blocker

=== APPROVED ===
Comment 4 Shawn Iwinski 2020-03-14 15:44:55 UTC 
Thanks for the review

https://pagure.io/releng/fedora-scm-requests/issue/23129
https://pagure.io/releng/fedora-scm-requests/issue/23130
https://pagure.io/releng/fedora-scm-requests/issue/23131
Comment 5 Gwyn Ciesla 2020-03-14 20:10:52 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-webimpress-safe-writer
Comment 6 Fedora Update System 2020-03-15 02:21:28 UTC 
FEDORA-2020-bd0c930d6d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-bd0c930d6d
Comment 7 Fedora Update System 2020-03-15 02:21:31 UTC 
FEDORA-2020-24ab48bb12 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-24ab48bb12
Comment 8 Fedora Update System 2020-03-15 14:30:06 UTC 
php-webimpress-safe-writer-2.0.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-bd0c930d6d
Comment 9 Fedora Update System 2020-03-16 14:12:49 UTC 
php-webimpress-safe-writer-2.0.0-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-24ab48bb12
Comment 10 Fedora Update System 2020-03-23 02:37:43 UTC 
php-webimpress-safe-writer-2.0.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2020-03-23 20:24:05 UTC 
FEDORA-2020-24ab48bb12 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.