Bug 1806927

Summary:	[RFE] Add the branch (b) to certain time feature in atop
Product:	Red Hat Enterprise Linux 8	Reporter:	Yogesh Babar <ybabar>
Component:	pcp	Assignee:	Nathan Scott <nathans>
Status:	CLOSED ERRATA	QA Contact:	Jan Kurik <jkurik>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.0	CC:	agerstmayr, jkurik, mgoodwin, nathans, patrickm
Target Milestone:	rc	Keywords:	FutureFeature, Triaged
Target Release:	8.0	Flags:	pm-rhel: mirror+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	pcp-5.2.0	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-18 15:19:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yogesh Babar 2020-02-25 10:22:23 UTC

Description of problem:

The b and e switches work absolutely fine on a command line for example: 

# pcp atop -r  /var/log/pcp/pmlogger/fedorab/20200221.09.30.0.xz -b 09:48 -e 09:50

the atop will start at sharp 09:48 and would end by 09:50 but it does not accept the b and e in interactive mode. So please consider this RFE. 

Version-Release number of selected component (if applicable):

pcp-4.3.0-3.el8.x86_64

How reproducible:


Steps to Reproduce:
1. run pcp atop on an archive 
2. press b 
3. 

Actual results:

it will throw the "not yet supported in this atop!" error

Expected results:
It would be great if the atop accepts the b and e options. 


Additional info:

The RFE is not a request from a customer. Rather it is from the support engineer's perspective. The PCP adoption is not great among the support engineers and that is what I am trying to improve by documenting the PCP. This particular RFE can get the lowest priority.

Comment 1 Nathan Scott 2020-03-20 03:41:37 UTC

Just a quick clarification, the interactive key 'b' in [pcp-]atop indicates 'branch to certain time stamp' and not 'begin' time as it does on the command line.  The semantics are 'sample from this time stamp onward' and it must still be between the begin/end times given on the command line (which are the archive boundaries, by default, but can be used to provide a restricted time window).

The interactive 'e' key is unrelated - it displays GPU metrics if available.

Comment 2 Yogesh Babar 2020-03-20 04:35:25 UTC

(In reply to Nathan Scott from comment #1)
> Just a quick clarification, the interactive key 'b' in [pcp-]atop indicates
> 'branch to certain time stamp' and not 'begin' time as it does on the
> command line.  The semantics are 'sample from this time stamp onward' and it
> must still be between the begin/end times given on the command line (which
> are the archive boundaries, by default, but can be used to provide a
> restricted time window).
> 
> The interactive 'e' key is unrelated - it displays GPU metrics if available.

Thanks for the clarification, Nathan.

Comment 3 Nathan Scott 2020-07-22 07:48:48 UTC

This is fixed upstream via the following commit:

commit d3011a416e318697ee1a7c9d406e4766b2ee3cd7
Author: Nathan Scott <nathans>
Date:   Wed Jul 22 17:45:32 2020 +1000

    pcp-atop: implement several RFEs relating to time navigation
    
    Adds interactive mode (i) in atop for changing time interval.
    Adds the branch (b) to certain time feature in atop.
    
    Fixes option 'T' for stepping backward one sample in time and
    also enables 'k' option for localhost contexts.
    
    Resolves Red Hat BZs 1806824, 1847925 and 1806927.

Comment 4 Yogesh Babar 2020-07-27 05:27:55 UTC

(In reply to Nathan Scott from comment #3)
> This is fixed upstream via the following commit:
> 
> commit d3011a416e318697ee1a7c9d406e4766b2ee3cd7
> Author: Nathan Scott <nathans>
> Date:   Wed Jul 22 17:45:32 2020 +1000
> 
>     pcp-atop: implement several RFEs relating to time navigation
>     
>     Adds interactive mode (i) in atop for changing time interval.
>     Adds the branch (b) to certain time feature in atop.
>     
>     Fixes option 'T' for stepping backward one sample in time and
>     also enables 'k' option for localhost contexts.
>     
>     Resolves Red Hat BZs 1806824, 1847925 and 1806927.

Thanks for the info. I will wait for this addition.

Comment 12 errata-xmlrpc 2021-05-18 15:19:30 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcp bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1754