Bug 1807520
| Summary: | malaga-suomi-voikko requires Python 2 to build | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Viktorin (pviktori) <pviktori> |
| Component: | malaga-suomi-voikko | Assignee: | Ville-Pekka Vainio <vpvainio> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 34 | CC: | mfabian, mhroncok, vpvainio |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-03-19 16:42:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1803205, 1913679 | ||
|
Description
Petr Viktorin (pviktori)
2020-02-26 14:41:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle. Changing version to 33. Ville-Pekka, do you have answers to the questions above? PR with attempt to port: https://src.fedoraproject.org/rpms/malaga-suomi-voikko/pull-request/2 Hi Petr! You would test the change by building the package. Seems to me it's working. Which tool did you use to see voikko/generate_lex.py is the only file requiring changes? The thing is, I am slowly working on updating the whole Finnish spell checking stack and progress has been slower than I planned. I have a bit more than a month before the beta freeze, though. With some luck, that would be enough. In upstream, this package has already been replaced by the voikko-fi package, which is Python 3 compatible from the start. Terve, Ville-Pekka!
Glad to hear that things are moving forward. Thank you for your work!
It's OK to continue using Python 2 to build, even for f34. If voikko-fi isn't ready by f35, the patch can be merged then.
> Which tool did you use to see voikko/generate_lex.py is the only file requiring changes?
Well, I ran the build with Python 3 instead of Python 2, and fixed the file that gave me errors ;)
(In reply to Petr Viktorin from comment #5) > It's OK to continue using Python 2 to build, even for f34. If voikko-fi > isn't ready by f35, the patch can be merged then. Good to hear :) I'll leave the bug report open and we'll see how things go. I think I fixed it in F34 and rawhide. I had made almost exactly the same change as in https://src.fedoraproject.org/rpms/malaga-suomi-voikko/pull-request/2 in RHEL8 in July 2018 already and there were no complaints so far. So I think this fix is OK. > I think I fixed it in F34 and rawhide.
$ repoquery --repo=koji-source malaga-suomi-voikko
malaga-suomi-voikko-0:1.19-13.fc34.src
$ repoquery --repo=koji-source --requires malaga-suomi-voikko | grep py
python2
It appears the commit was never built.
(In reply to Miro Hrončok from comment #8) > It appears the commit was never built. The malaga-suomi-voikko and the malaga packages have been obsoleted by the voikko-fi package now. I have not retired the malaga-suomi-voikko package yet, I'm a bit busy today. I will try to find the time to retire it tomorrow. The malaga package could be useful for someone, but it has not been maintained upstream for years. I might just orphan it and let people know on the mailing list. > I have not retired the malaga-suomi-voikko package yet, I'm a bit busy today. I will try to find the time to retire it tomorrow.
Would you like me to do it?
(In reply to Miro Hrončok from comment #10) > > I have not retired the malaga-suomi-voikko package yet, I'm a bit busy today. I will try to find the time to retire it tomorrow. > > Would you like me to do it? I forgot, I'm sorry. Yes, please. Committed, waiting for a compose. |