Bug 1807812

Summary:	oc image mirror --from-dir does not override --dir
Product:	OpenShift Container Platform	Reporter:	Paul Weil <pweil>
Component:	oc	Assignee:	Maciej Szulik <maszulik>
Status:	CLOSED ERRATA	QA Contact:	XiuJuan Wang <xiuwang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	aos-bugs, jokerman, maszulik, mfojtik, yinzhou
Target Milestone:	---	Keywords:	NeedsTestCase
Target Release:	4.3.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1807810	Environment:
Last Closed:	2020-03-24 14:34:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1807810
Bug Blocks:

Description Paul Weil 2020-02-27 10:01:44 UTC

+++ This bug was initially created as a clone of Bug #1807810 +++

+++ This bug was initially created as a clone of Bug #1807807 +++

Description of problem: Complete gives error error: you must specify at least one source image to pull and the destination to push to as SRC=DST or SRC DST [DST2 DST3 ...] if only --from-dir is specified even though it is supposed to override --dir.



How reproducible: Always


Steps to Reproduce:
1. mirror a release to a directory using 'release mirror' command
2. attempt to mirror the directory back to a registry with 'image mirror' command specifying --from-dir (do not speicfy --dir)

./oc image mirror -a ${LOCAL_SECRET_JSON} --from-dir=/tmp/mirror-file file://openshift/release:4.3.3* ${LOCAL_REGISTRY}/ocp-4.3


Actual results:
error: you must specify at least one source image to pull and the destination to push to as SRC=DST or SRC DST [DST2 DST3 ...]


Expected results: directory mirrors to registry

Comment 3 XiuJuan Wang 2020-03-10 09:28:20 UTC

Could reproduce with old client.
Test with client 4.3.6-202003090404-79a17e7, and passed

./oc version 
Client Version: 4.3.6-202003090404-79a17e7
Server Version: 4.3.0-0.nightly-2020-03-09-200240
Kubernetes Version: v1.16.2

Cmd 
[1] $oc image mirror -a /tmp/kubeconfig/vsphere-mirror.json --from-dir=bz1807812 file://openshift/release:4.3.0-0.nightly-2020-03-09-200240* vsphere.mirror-registry.qe.devcluster.openshift.com:5000/xiuwang43

[2] $oc image mirror -a /tmp/kubeconfig/vsphere-mirror.json --dir=bz1807812 file://openshift/release:4.3.0-0.nightly-2020-03-09-200240*  vsphere.mirror-registry.qe.devcluster.openshift.com:5000/xiuwang431

[3] $oc image mirror -a /tmp/kubeconfig/vsphere-mirror.json --from-dir=bz1807812 file://openshift/release:4.3.0-0.nightly-2020-03-09-200240* vsphere.mirror-registry.qe.devcluster.openshift.com:5000/xiuwang43 --dir=notexist

[4] $oc image mirror -a /tmp/kubeconfig/vsphere-mirror.json --dir=bz1807812 file://openshift/release:4.3.0-0.nightly-2020-03-09-200240* vsphere.mirror-registry.qe.devcluster.openshift.com:5000/xiuwang43 --from-dir=notexist

Cmd [1] [2] [3] passed without error, mirroring images successfully.
[4] failed as expected, "error: you must specify at least one source image to pull and the destination to push to as SRC=DST or SRC DST [DST2 DST3 ...]"

Comment 5 errata-xmlrpc 2020-03-24 14:34:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0858