Bug 1807883

Summary: Can't create a VM on firefox due to an "invalid regexp group" error
Product: [oVirt] ovirt-engine Reporter: shani <sleviim>
Component: Backend.CoreAssignee: Lucia Jelinkova <ljelinko>
Status: CLOSED CURRENTRELEASE QA Contact: Daniel <dmaaravi>
Severity: high Docs Contact:
Priority: high    
Version: 4.4.0CC: bugs, ljelinko, michal.skrivanek, rbarry, tnisan
Target Milestone: ovirt-4.4.0Flags: pm-rhel: ovirt-4.4+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.0 gitb5b5c99ca2f Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:01:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Can't create a VM on firefox due to an "invalid regexp group" error none

Description shani 2020-02-27 12:26:41 UTC 
Created attachment 1666186 [details]
Can't create a VM on firefox due to an "invalid regexp group" error

Description of problem:
When trying to create a new VM from firefox, there's a UI error:
Uncaught exception: com.google.gwt.event.shared.UmbrellaException: Exception caught: (SyntaxError) : invalid regexp group.

Full log:
2020-02-27 13:15:28,936+02 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-7) [] Permutation name: A6DF592993D794C4420A3CB962C38C11
2020-02-27 13:15:28,936+02 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-7) [] Uncaught exception: com.google.gwt.event.shared.UmbrellaException: Exception caught: (SyntaxError) : invalid regexp group
        at java.lang.Throwable.Throwable(Throwable.java:70)
        at java.lang.RuntimeException.RuntimeException(RuntimeException.java:32)
        at com.google.web.bindery.event.shared.UmbrellaException.UmbrellaException(UmbrellaException.java:64)
        at com.google.gwt.event.shared.UmbrellaException.UmbrellaException(UmbrellaException.java:25)
        at com.google.gwt.event.shared.HandlerManager.$fireEvent(HandlerManager.java:117)
        at com.google.gwt.user.client.ui.Widget.$fireEvent(Widget.java:127)
        at com.google.gwt.user.client.ui.Widget.fireEvent(Widget.java:127)
        at com.google.gwt.event.dom.client.DomEvent.fireNativeEvent(DomEvent.java:110)
        at com.google.gwt.user.client.ui.Widget.$onBrowserEvent(Widget.java:163)
        at com.google.gwt.user.client.ui.Widget.onBrowserEvent(Widget.java:163)
        at com.google.gwt.user.client.DOM.dispatchEvent(DOM.java:1415)
        at com.google.gwt.user.client.impl.DOMImplStandard.dispatchEvent(DOMImplStandard.java:312)
        at com.google.gwt.core.client.impl.Impl.apply(Impl.java:236)
        at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:275)
        at Unknown.bv/<(http://sleviim.redhat:8080/ovirt-engine/webadmin/?locale=en_US line 9 > scriptElement)
        at Unknown.anonymous(Unknown)
Caused by: com.google.gwt.core.client.JavaScriptException: (SyntaxError) : invalid regexp group
        at org.ovirt.engine.core.compat.Regex.Regex(Regex.java:45)
        at org.ovirt.engine.core.compat.Regex.isMatch(Regex.java:11)
        at org.ovirt.engine.ui.uicommonweb.validation.RegexValidation.$validate(RegexValidation.java:48)
        at org.ovirt.engine.ui.uicommonweb.validation.RegexValidation.validate(RegexValidation.java:48)
        at org.ovirt.engine.ui.uicommonweb.models.EntityModel.$validateEntity(EntityModel.java:121)
        at org.ovirt.engine.ui.uicommonweb.models.vms.UnitVmModel.$validateNaming(UnitVmModel.java:2981)
        at org.ovirt.engine.ui.uicommonweb.models.vms.UnitVmModel.$validate(UnitVmModel.java:2879)
        at org.ovirt.engine.ui.uicommonweb.models.templates.VmBaseListModel.$validateVm(VmBaseListModel.java:318)
        at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.$preSavePhase3(VmListModel.java:1684)
        at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.$preSavePhase2(VmListModel.java:1651)
        at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.$preSave(VmListModel.java:1617)
        at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.$executeCommand(VmListModel.java:2085)
        at org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.executeCommand(VmListModel.java:2085)
        at org.ovirt.engine.ui.uicommonweb.UICommand.$execute(UICommand.java:163)
        at org.ovirt.engine.ui.common.presenter.AbstractModelBoundPopupPresenterWidget.$lambda$4(AbstractModelBoundPopupPresenterWidget.java:306)
        at org.ovirt.engine.ui.common.presenter.AbstractModelBoundPopupPresenterWidget$lambda$4$Type.onClick(AbstractModelBoundPopupPresenterWidget.java:306)
        at com.google.gwt.event.dom.client.ClickEvent.dispatch(ClickEvent.java:55)
        at com.google.gwt.event.shared.GwtEvent.dispatch(GwtEvent.java:76)
        at com.google.web.bindery.event.shared.SimpleEventBus.$doFire(SimpleEventBus.java:173)
        ... 12 more

Creating VMs on chrome seems to work fine.

Version-Release number of selected component (if applicable):
ovirt-engine 4.4.0_master-f099897ae2c
firefox-73.0-2.fc30.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Try to create a VM on firefox

Actual results:
A UI "invalid regexp group" error

Expected results:
The operation should be succeeded.

Additional info:
Attached screenshot.
Comment 1 Michal Skrivanek 2020-02-28 13:29:35 UTC 
caused by https://gerrit.ovirt.org/106845, reverted by https://gerrit.ovirt.org/#/c/107287/
Comment 2 Sandro Bonazzola 2020-03-16 08:59:19 UTC 
This bug is in Modified state and targeting 4.4.1. Can we retarget this to 4.4.0 and move to QA?
Comment 3 Daniel 2020-04-05 06:54:57 UTC 
Verified via web-admin, tried it on the latest firefox version and it worked as expected.
VM created and no errors were raised both UI & logs.

Firefox version:
74.0.1 (64-bit)

Env' versions:
rhvm-4.4.0-0.29.master.el8ev.noarch
vdsm-jsonrpc-java-1.5.4-1.el8ev.noarch
qemu-kvm-4.2.0-16.module+el8.2.0+6092+4f2391c1.x86_64
libvirt-client-6.0.0-15.module+el8.2.0+6106+b6345808.x86_64
Comment 4 Sandro Bonazzola 2020-05-20 20:01:26 UTC 
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.