Bug 1808410
| Summary: | Call connection failure | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brian J. Murrell <brian.murrell> | ||||||||||||
| Component: | libnice | Assignee: | Stefan Becker <chemobejk> | ||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||
| Severity: | high | Docs Contact: | |||||||||||||
| Priority: | unspecified | ||||||||||||||
| Version: | 30 | CC: | bdpepple, chemobejk, kdudka, philip, svashisht, uraeus | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | x86_64 | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | libnice-0.1.16-8.fc30 libnice-0.1.16-8.fc31 libnice-0.1.16-8.fc32 | Doc Type: | If docs needed, set a value | ||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2020-03-08 00:08:32 UTC | Type: | Bug | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Brian J. Murrell
2020-02-28 12:45:29 UTC
Thanks! Let's wait to see whether a new release is planned. If not, we will pick the mentioned change only. Patch as such doesn't apply, needs rebase for our code base Created attachment 1666459 [details]
Upstream merged request rebased to Fedora code base
Can reporter please confirm that this rebased patch fixes his issue?
Created attachment 1666460 [details]
patch
Indeed. I'll attach my attempt (works at least) at resolving the merge conflicts.
Created attachment 1666461 [details]
patch
FWIW, I also have this patch in my local build.
I've tested https://src.fedoraproject.org/rpms/libnice/blob/f30/f/libnice.spec + attachment #1666459 [details] and it does not work. There must be something in https://src.fedoraproject.org/rpms/libnice/blob/f30/f/libnice-0.1.16-16-gb998547.patch that is not in attachment #1666461 [details] patch that is preventing the connection from completing. (In reply to Brian J. Murrell from comment #6) > There must be something in > https://src.fedoraproject.org/rpms/libnice/blob/f30/f/libnice-0.1.16-16-gb998547.patch > that is not in attachment #1666461 [details] patch that is preventing the connection from completing. Actually I'm not surprised, because why would getifaddrs() fail on a normal Linux distro, i.e. why would that change fix your issue? Taking and educated guess from the differences between my and your rebase I think the your issue is actually fixed by * https://gitlab.freedesktop.org/libnice/libnice/-/commit/bd4b47813844aa0e68e9074b3ac516c383ca8bab (from https://gitlab.freedesktop.org/libnice/libnice/-/merge_requests/66) * https://gitlab.freedesktop.org/libnice/libnice/-/merge_requests/107 (I just submitted that, because merge request !66 missed the 2nd spot) Created attachment 1666466 [details]
Fix incorrectly ignored interfaces (1/2)
Created attachment 1666467 [details]
Fix incorrectly ignored interfaces (2/2)
Two upstream patches that fix the issue of the first ignored interface causing all further interfaces to be ignored.
Given the number of patches we are talking about now and the ease of confusion here, would it be easy enough for you to do a scratch build (koji/bodhi or whatever that all is) of a libnice that includes all of the patches you want me to test? (In reply to Brian J. Murrell from comment #10) > would it be easy enough for you to do a scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=41997034 Yeah, that works. Yay! Thanks much! FEDORA-2020-0873b72ac7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0873b72ac7 FEDORA-2020-99df8540a8 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-99df8540a8 libnice-0.1.16-8.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-107faf279e libnice-0.1.16-8.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0873b72ac7 libnice-0.1.16-8.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-99df8540a8 Thank you for fixing it, Stefan! libnice-0.1.16-8.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. libnice-0.1.16-8.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. libnice-0.1.16-8.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. libnice-0.1.16-8.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report. |