Bug 1809469

Summary:	Review Request: tidb-server - A distributed NewSQL database compatible with MySQL protocol
Product:	[Fedora] Fedora	Reporter:	guoqiang
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedora, itamar, package-review, sztsian
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-06 20:30:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841

Description guoqiang 2020-03-03 08:14:11 UTC

Hello~

It's the first time for me to pack a (s)rpm, and I am seeking a sponsor.
The srpm is created with pre-compiled binaries from https://download.pingcap.org/tidb-v3.0.8-linux-arm64.tar.gz, and config files from https://github.com/pingcap/tidb.

There has been a successful build on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=42131115

Spec URL:
It's in the SRPM.https://kojipkgs.fedoraproject.org//work/tasks/1291/42131291/tidb-server-v3.0.8-1.el7.src.rpm
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1291/42131291/tidb-server-v3.0.8-1.el7.src.rpm

Description:
TiDB is an open-source NewSQL database that supports Hybrid Transactional and Analytical Processing (HTAP) workloads. It is MySQL compatible and features horizontal scalability, strong consistency, and high availability.

TiDB features:
* Horizontal Scalability
* MySQL Compatible Syntax
* Distributed Transactions with Strong Consistency
* Cloud Native
* Minimize ETL
* High Availability

Fedora Account System Username: n0vad3v

Comment 1 Zamir SUN 2020-03-03 11:03:36 UTC

Please update SPEC URL with the actual URL instead of a SRPM.
And please compile the binary in the build section rather than submit a srpm with pre-build binary, which is not allowed in Fedora.

Comment 2 Artur Frenszek-Iwicki 2020-03-03 12:12:18 UTC

>Group:          Applications/Databases
The "Group:" tag is not used in Fedora.
>%clean
Ditto for the "%clean" section.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>%description
%TiDB is an open-source NewSQL database that supports Hybrid Transactional and Analytical Processing (HTAP) workloads. It is MySQL compatible and features horizontal scalability, strong consistency, and high availability.
The description should be broken down into multiple lines, each one no longer than 80 characters.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

>%{__mkdir} -p %{buildroot}%{_bindir}
>%{__install} -D -m 0644 %{SOURCE1} %{buildroot}%{_sysconfdir}/tidb/config.toml
Macro forms of system executables should not be used.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros

Comment 3 Itamar Reis Peixoto 2020-06-06 20:30:38 UTC

your src.rpm is returning 404, please upload it again and reopen this ticket.