Bug 1809751

Summary: [ESXi][RHEL8.2.1]open-vm-tools add appinfo plugin patch
Product: Red Hat Enterprise Linux 8 Reporter: Cathy Avery <cavery>
Component: open-vm-toolsAssignee: Cathy Avery <cavery>
Status: CLOSED ERRATA QA Contact: ldu <ldu>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.2CC: biyiklioglu, boyang, cavery, gchua, jen, jjarvis, jsavanyo, kanderso, ldu, leiwang, ravindrakumar, ribarry, vkuznets, vmware-gos-qa, yacao, yanjin
Target Milestone: rcKeywords: FutureFeature
Target Release: 8.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: open-vm-tools-11.0.5-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-21 15:30:14 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Cathy Avery 2020-03-03 19:44:49 UTC
Add patch https://github.com/vmware/open-vm-tools/commit/f1f0b812e7fb9ccf405fcfd48ddb4d65e8532eef to open-vm-tools 11.0.5

Comment 1 Cathy Avery 2020-03-09 12:19:02 UTC
John or Ravindra,

We need directions on how to test this patch.

Thanks!

Comment 2 ldu 2020-03-10 09:42:18 UTC
Hi Ravindra JinYan,
Follow the document "Configuring appInfo", I run command vmware-rpctool "info-get guestinfo.appInfo" and vmtoolsd --cmd "info-get guestinfo.appInfo", both of two command I have tried on our guest, after run these command, then could list all application in guest. it seems like below:
[root@vm-197-32 ~]# vmware-rpctool "info-get guestinfo.appInfo" |grep firefox
{"a":"firefox","v":""},
{"a":"firefox","v":""},
{"a":"firefox","v":""},
{"a":"firefox","v":""},
{"a":"firefox","v":""},

Also tried command vmware-toolbox-cmd config set appinfo poll-interval xx(value) and vmware-toolbox-cmd config set appinfo disabled true, except these functional test, do you have any other test cases to cover this feature?
Thanks very mcuh!

Lili Du

Comment 3 GOS QA 2020-03-10 12:05:03 UTC
(In reply to ldu from comment #2)
> Hi Ravindra JinYan,
> Follow the document "Configuring appInfo", I run command vmware-rpctool
> "info-get guestinfo.appInfo" and vmtoolsd --cmd "info-get
> guestinfo.appInfo", both of two command I have tried on our guest, after run
> these command, then could list all application in guest. it seems like below:
> [root@vm-197-32 ~]# vmware-rpctool "info-get guestinfo.appInfo" |grep firefox
> {"a":"firefox","v":""},
> {"a":"firefox","v":""},
> {"a":"firefox","v":""},
> {"a":"firefox","v":""},
> {"a":"firefox","v":""},
> 
> Also tried command vmware-toolbox-cmd config set appinfo poll-interval
> xx(value) and vmware-toolbox-cmd config set appinfo disabled true, except
> these functional test, do you have any other test cases to cover this
> feature?
> Thanks very mcuh!
> 
> Lili Du

Hi Lili,
It's so great that you can figure out the testing by following the document.
Can you share us the patch file? so that I can do some testing in our test environment.
Yan Jin

Comment 4 Ravindra Kumar 2020-03-10 17:54:55 UTC
Just test as described in https://docs.vmware.com/en/VMware-Tools/11.0.0/com.vmware.vsphere.vmwaretools.doc/GUID-3A8089F6-CAF6-43B9-BD9D-B1081F8D64E2.html.

Additionally, ensure that following command returns no value when you set the poll-interval to 0 or disable the appInfo plugin:

$ vmtoolsd --cmd “info-get guestinfo.appInfo”

Comment 5 John Savanyo 2020-03-10 18:54:30 UTC
Please advise if you need help testing, but you would need to provide us access to build to test.

-John

Comment 6 ldu 2020-03-11 02:08:04 UTC
@Ravindra,@YanJin,@John, Thanks very much!
I had tried command set the poll-interval to 0 or disable the appInfo plugin, indeed no value return.

@YanJin, I have upload the test build to link http://people.redhat.com/ldu/rpm/
This test build is for RHEL7, you can download and try it, if any problem, please contact me freely!

BRs,
Lili Du

Comment 7 Yan Jin 2020-03-12 05:14:08 UTC
Hi Lili,
Thanks for sharing the open-vm-tools packages for RHEL 7.
I have done my testing for appinfo,  did not hit any issue about AppInfo feature.
My test Env:
VM: RHEL 7.8 RC (covering Minimal & Server with GUI) + provided open-vm-tools 11.0.5 from http://people.redhat.com/ldu/rpm/.
Host: ESXi 6.5 GA and 6.7U3

In the VM 
1. set poll-interval in /etc/vmware-tools/tools.conf like below
[appinfo]
disabled = false
poll-interval = 10

2. start some new processes or kill some existing processes
3. check with command "ps aux | grep xxx"

From ESXi host
1. check AppInfo by running following 2 commands in the ESXi shell:

## Get the VMID for the tested VM
# vim-cmd vmsvc/getallvms
## Get AppInfo for the tested VM
# vim-cmd vmsvc/get.config <VMID> | grep xxx

From both sides the listed Apps are the same.
===========================================
But I get a warning by rpm install the provided open-vm-tools 
# rpm -i open-vm-tools-11.0.5-2.el7.cavery202003040731.x86_64.rpm
/var/tmp/rpm-tmp.693dNa: line 1: ?ldconfig: command not found

Comment 8 ldu 2020-03-12 11:16:46 UTC
@YanJin, Thanks very much for your test!
For the warning message, indeed it also have when install with yum.


Cathy,
Could you help check this "/var/tmp/rpm-tmp.EM0IFG: line 1: ?ldconfig: command not found" message? 
Total                                                                                                                                                                              245 kB/s | 1.1 MB     00:04     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                                           1/1 
  Running scriptlet: compat-openssl10-1:1.0.2o-3.el8.x86_64                                                                                                                                                    1/1 
  Installing       : compat-openssl10-1:1.0.2o-3.el8.x86_64                                                                                                                                                    1/5 
  Running scriptlet: compat-openssl10-1:1.0.2o-3.el8.x86_64                                                                                                                                                    1/5 
  Upgrading        : open-vm-tools-11.0.5-2.el7.cavery202003040731.x86_64                                                                                                                                      2/5 
  Running scriptlet: open-vm-tools-11.0.5-2.el7.cavery202003040731.x86_64                                                                                                                                      2/5 
/var/tmp/rpm-tmp.EM0IFG: line 1: ?ldconfig: command not found

  Upgrading        : open-vm-tools-desktop-11.0.5-2.el7.cavery202003040731.x86_64                                                                                                                              3/5 
  Running scriptlet: open-vm-tools-desktop-11.0.5-2.el7.cavery202003040731.x86_64                                                                                                                              3/5 
  Cleanup          : open-vm-tools-desktop-11.0.0-4.el8.x86_64                                                                                                                                                 4/5 
  Running scriptlet: open-vm-tools-11.0.0-4.el8.x86_64                                                                                                                                                         5/5 
  Cleanup          : open-vm-tools-11.0.0-4.el8.x86_64                                                                                                                                                         5/5 
  Running scriptlet: open-vm-tools-11.0.0-4.el8.x86_64                                                                                                                                                         5/5 
  Verifying        : compat-openssl10-1:1.0.2o-3.el8.x86_64                                                                                                                                                    1/5 
  Verifying        : open-vm-tools-11.0.5-2.el7.cavery202003040731.x86_64                                                                                                                                      2/5 
  Verifying        : open-vm-tools-11.0.0-4.el8.x86_64                                                                                                                                                         3/5 
  Verifying        : open-vm-tools-desktop-11.0.5-2.el7.cavery202003040731.x86_64                                                                                                                              4/5 
  Verifying        : open-vm-tools-desktop-11.0.0-4.el8.x86_64                                                                                                                                                 5/5 
Installed products updated.

Upgraded:
  open-vm-tools-11.0.5-2.el7.cavery202003040731.x86_64                                                 open-vm-tools-desktop-11.0.5-2.el7.cavery202003040731.x86_64                                                

Installed:
  compat-openssl10-1:1.0.2o-3.el8.x86_64                                                                                                                                                                           

Complete!
[root@vm-197-198 ~]#

Comment 9 Cathy Avery 2020-03-12 14:12:32 UTC
(In reply to ldu from comment #8)

> Cathy,
> Could you help check this "/var/tmp/rpm-tmp.EM0IFG: line 1: ?ldconfig:
> command not found" message? 

It is either complaining about ldconfig (glibc rpm) not being installed or that there is a bogus command to ldconfig.

Could you see if glibc is installed and what the rev is? 


@Ravindra could you take a look at the error message they are getting. It looks like there is a package dependency issue.

Thanks,

Cathy

Comment 10 Ravindra Kumar 2020-03-12 17:59:06 UTC
This commit https://src.fedoraproject.org/rpms/open-vm-tools/c/4f1758de5373a88d7a944241741ee309383bc476?branch=f27 added that macro.

In Fedora 28+ these are not needed. We need to remove these going forward from Fedora.

However, we need these for RHEL 7.x. Could you please replace "%{?ldconfig}" lines with "/sbin/ldconfig" and try?

This will also need following dependencies:

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

Is the new package working fine for RHEL 8?

Comment 11 Cathy Avery 2020-03-12 18:35:15 UTC
(In reply to Ravindra Kumar from comment #10)
> This commit
> https://src.fedoraproject.org/rpms/open-vm-tools/c/
> 4f1758de5373a88d7a944241741ee309383bc476?branch=f27 added that macro.
> 
> In Fedora 28+ these are not needed. We need to remove these going forward
> from Fedora.
> 
> However, we need these for RHEL 7.x. Could you please replace "%{?ldconfig}"
> lines with "/sbin/ldconfig" and try?
> 
> This will also need following dependencies:
> 
> Requires(post): /sbin/ldconfig
> Requires(postun): /sbin/ldconfig
> 
> Is the new package working fine for RHEL 8?

Could you please send a patch?

Cathy

Comment 12 ldu 2020-03-13 02:16:00 UTC
Hi Cathy,
As our test build is for RHEL7, could you help build one test build for RHEL8?
I can help test it to avoid regression issue!
Thanks,

Lili Du

Comment 13 Cathy Avery 2020-03-13 12:21:47 UTC
(In reply to ldu from comment #12)
> Hi Cathy,
> As our test build is for RHEL7, could you help build one test build for
> RHEL8?
> I can help test it to avoid regression issue!
> Thanks,
> 
> Lili Du

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=27246716

Comment 14 ldu 2020-03-18 13:35:16 UTC
Hi Cathy, Ravindra,
The test build works well on RHEL8, I had verified it on RHEL8.2 guest. The command get appinfo all works well, disable the appInfo plugin also works. There is no warning message /var/tmp/rpm-tmp.EM0IFG: line 1: ?ldconfig: command not found on RHEL8.

Thanks,

Lili Du

Comment 15 Cathy Avery 2020-03-26 12:11:37 UTC
Patch has been supplied.

Comment 24 ldu 2020-05-14 10:19:06 UTC
Verified this bug with open-vm-tools-11.0.5-3.el8.
All appinfo test case passed.
So change status to verified.

Comment 26 errata-xmlrpc 2020-07-21 15:30:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:3049