Bug 1809908

Summary:	Review Request: R-profvis - Interactive Visualizations for Profiling R Code
Product:	[Fedora] Fedora	Reporter:	Elliott Sales de Andrade <quantum.analyst>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jamatos, package-review
Target Milestone:	---	Flags:	jamatos: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-14 00:36:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Elliott Sales de Andrade 2020-03-04 06:56:00 UTC

Spec URL: https://qulogic.fedorapeople.org//R-profvis.spec
SRPM URL: https://qulogic.fedorapeople.org//R-profvis-0.3.6-1.fc30.src.rpm

Description:
b'Interactive visualizations for profiling R code.'

Comment 1 Elliott Sales de Andrade 2020-03-04 06:56:02 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=42168989

Comment 2 José Matos 2020-03-04 13:11:43 UTC

This is what fedora-review has to say about it:

- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/lib64/R/library/profvis/htmlwidgets/lib/d3/LICENSE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

As discussed in other reviews some issues are not true and other are moot.
My main issue is with the bundle js packages but they are clearly labelled as such and can be changed later if the scenario changes.

The package is approved.

Comment 3 Gwyn Ciesla 2020-03-04 21:47:19 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-profvis

Comment 4 Fedora Update System 2020-03-04 22:50:47 UTC

FEDORA-2020-01d3e846c7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-01d3e846c7

Comment 5 Fedora Update System 2020-03-04 22:51:31 UTC

FEDORA-2020-f4cb575146 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f4cb575146

Comment 6 Fedora Update System 2020-03-05 19:36:21 UTC

R-profvis-0.3.6-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-01d3e846c7

Comment 7 Fedora Update System 2020-03-06 03:39:05 UTC

R-profvis-0.3.6-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f4cb575146

Comment 8 Fedora Update System 2020-03-14 00:36:36 UTC

R-profvis-0.3.6-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-03-16 20:33:40 UTC

R-profvis-0.3.6-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.