Bug 1809939

Summary: UC install fails with Could not find class ::tripleo::profile::base::neutron::dhcp_agent_wrappers
Product: Red Hat OpenStack Reporter: Michele Baldessari <michele>
Component: openstack-tripleo-heat-templatesAssignee: RHOS Maint <rhos-maint>
Status: CLOSED ERRATA QA Contact: Sasha Smolyak <ssmolyak>
Severity: urgent Docs Contact:
Priority: high    
Version: 16.0 (Train)CC: akaris, aschultz, beagles, drosenfe, emacchi, fhubik, jfrancoa, jhajyahy, kecarter, mburns, ramishra, wznoinsk, yobshans
Target Milestone: ---Keywords: OtherQA, Reopened, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-03 21:05:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michele Baldessari 2020-03-04 09:14:00 UTC
Description of problem:
This is from today's puddle RHOS_TRUNK-16.0-RHEL-8-20200304.n.0 which has:
puppet-tripleo-11.4.1-0.20200303110227.65d6cb1.el8ost.noarch                  
openstack-tripleo-heat-templates-11.3.2-0.20200302235623.5ac7a8c.el8ost.noarch  

The problem to me seems that via a downstream backport https://code.engineering.redhat.com/gerrit/#/c/190736/ we brought the following code back (I think accidentally really):
    docker_config:
        step_2:
          create_dnsmasq_wrapper:
            start_order: 1
            detach: false
            net: host
            pid: host
            user: root
            command: # '/container_puppet_apply.sh "STEP" "TAGS" "CONFIG" "DEBUG"'
              list_concat:
                -
                  - '/container_puppet_apply.sh'
                  - '4'
                  - 'file'
                  - 'include ::tripleo::profile::base::neutron::dhcp_agent_wrappers'
            image: {get_param: ContainerNeutronDHCPImage}
            volumes:
              list_concat:
                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}
                -
                  - /run/openvswitch:/run/openvswitch:shared,z
                  - /var/lib/neutron:/var/lib/neutron:shared,z

But this code relies on the existence of the neutron::dhcp_agent_wrappers class which is not there anymore.

See the broken bits here: http://pkgs.devel.redhat.com/cgit/rpms/openstack-tripleo-heat-templates/tree/0008-Add-DeployIdentifier-to-extra-config-containers.patch?h=rhos-16.0-rhel-8-trunk

Comment 1 Michele Baldessari 2020-03-04 09:52:06 UTC
Applying the following fixes my UC install:
diff -urN /usr/share/openstack-tripleo-heat-templates/deployment/neutron/neutron-dhcp-container-puppet.yaml /tmp/openstack-tripleo-heat-templates/deployment/neutron/neutron-dhcp-container-puppet.yaml
--- /usr/share/openstack-tripleo-heat-templates/deployment/neutron/neutron-dhcp-container-puppet.yaml	2020-03-03 00:12:25.000000000 +0000
+++ /tmp/openstack-tripleo-heat-templates/deployment/neutron/neutron-dhcp-container-puppet.yaml	2020-03-04 09:32:29.054263434 +0000
@@ -349,29 +349,6 @@
                       echo "/usr/sbin/haproxy -Ws"; fi)
                   kill_script: haproxy-kill
       docker_config:
-        step_2:
-          create_dnsmasq_wrapper:
-            start_order: 1
-            detach: false
-            net: host
-            pid: host
-            user: root
-            command: # '/container_puppet_apply.sh "STEP" "TAGS" "CONFIG" "DEBUG"'
-              list_concat:
-                -
-                  - '/container_puppet_apply.sh'
-                  - '4'
-                  - 'file'
-                  - 'include ::tripleo::profile::base::neutron::dhcp_agent_wrappers'
-            image: {get_param: ContainerNeutronDHCPImage}
-            volumes:
-              list_concat:
-                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}
-                -
-                  - /run/openvswitch:/run/openvswitch:shared,z
-                  - /var/lib/neutron:/var/lib/neutron:shared,z
-            environment:
-              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}
         step_4:
           neutron_dhcp:
             start_order: 10
diff -urN /usr/share/openstack-tripleo-heat-templates/deployment/neutron/neutron-l3-container-puppet.yaml /tmp/openstack-tripleo-heat-templates/deployment/neutron/neutron-l3-container-puppet.yaml
--- /usr/share/openstack-tripleo-heat-templates/deployment/neutron/neutron-l3-container-puppet.yaml	2020-03-03 00:12:25.000000000 +0000
+++ /tmp/openstack-tripleo-heat-templates/deployment/neutron/neutron-l3-container-puppet.yaml	2020-03-04 09:32:54.119180206 +0000
@@ -308,29 +308,6 @@
                   cmd: /usr/sbin/radvd -n
                   kill_script: radvd-kill
       docker_config:
-        step_2:
-          create_keepalived_wrapper:
-            start_order: 1
-            detach: false
-            net: host
-            pid: host
-            user: root
-            command: # '/container_puppet_apply.sh "STEP" "TAGS" "CONFIG" "DEBUG"'
-              list_concat:
-                -
-                  - '/container_puppet_apply.sh'
-                  - '4'
-                  - 'file'
-                  - 'include ::tripleo::profile::base::neutron::l3_agent_wrappers'
-            image: {get_param: ContainerNeutronL3AgentImage}
-            volumes:
-              list_concat:
-                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}
-                -
-                  - /run/openvswitch:/run/openvswitch:shared,z
-                  - /var/lib/neutron:/var/lib/neutron:shared,z
-            environment:
-              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}
         step_4:
           neutron_l3_agent:
             start_order: 10
diff -urN /usr/share/openstack-tripleo-heat-templates/deployment/ovn/ovn-metadata-container-puppet.yaml /tmp/openstack-tripleo-heat-templates/deployment/ovn/ovn-metadata-container-puppet.yaml
--- /usr/share/openstack-tripleo-heat-templates/deployment/ovn/ovn-metadata-container-puppet.yaml	2020-03-03 00:12:25.000000000 +0000
+++ /tmp/openstack-tripleo-heat-templates/deployment/ovn/ovn-metadata-container-puppet.yaml	2020-03-04 09:33:15.568108998 +0000
@@ -281,29 +281,6 @@
                       echo "/usr/sbin/haproxy -Ws"; fi)
                   kill_script: haproxy-kill
       docker_config:
-        step_2:
-          create_haproxy_wrapper:
-            start_order: 1
-            detach: false
-            net: host
-            pid: host
-            user: root
-            command: # '/container_puppet_apply.sh "STEP" "TAGS" "CONFIG" "DEBUG"'
-              list_concat:
-                -
-                  - '/container_puppet_apply.sh'
-                  - '4'
-                  - 'file'
-                  - 'include ::tripleo::profile::base::neutron::ovn_metadata_agent_wrappers'
-            image: {get_param: ContainerOvnMetadataImage}
-            volumes:
-              list_concat:
-                - {get_attr: [ContainersCommon, container_puppet_apply_volumes]}
-                -
-                  - /run/openvswitch:/run/openvswitch:shared,z
-                  - /var/lib/neutron:/var/lib/neutron:shared,z
-            environment:
-              TRIPLEO_DEPLOY_IDENTIFIER: {get_param: DeployIdentifier}
         step_4:
           setup_ovs_manager:
             start_order: 0

Comment 3 Michele Baldessari 2020-03-04 11:33:12 UTC
*** Bug 1809998 has been marked as a duplicate of this bug. ***

Comment 13 Rabi Mishra 2020-03-05 07:30:40 UTC
*** Bug 1810294 has been marked as a duplicate of this bug. ***

Comment 14 Michele Baldessari 2020-03-05 09:51:33 UTC
*** Bug 1810445 has been marked as a duplicate of this bug. ***

Comment 18 Andreas Karis 2020-03-09 09:30:07 UTC
Hi,

Customers are running into this. When can we expect an RPM that we can ship as a hotfix? Already requesting this by setting the hotfix requested flag.

- Andreas

Comment 20 Alex Schultz 2020-03-09 14:11:16 UTC
I'm not certain how folks are hitting this as this shouldn't have been shipped yet.

Comment 21 Alex Schultz 2020-03-09 14:29:30 UTC
I'm denying the hotfix. The issue stems from the hotfix for Bug 1810604. The provided images include the latest version of director packages and to hotfix just THT (as being requested) will also require additional matching packages (tripleo-ansible, tripleo-common, puppet-tripleo, paunch, etc). The solution for the customer would be to get the patch for Bug 1810604 applied to the latest released director content.

Comment 24 Red Hat Bugzilla 2024-01-06 04:28:19 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days