Bug 1810106

Summary: Can't open preferences in virt-manager
Product: [Community] Virtualization Tools Reporter: redhatbugzilla
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, crobinso, gscrivan, tburke
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-13 20:49:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description redhatbugzilla 2020-03-04 14:48:24 UTC
Description of problem:
I get an error when I try to access the preferences via the edit menu and the preferences dialog does not open.

Version-Release number of selected component (if applicable):
virt-manager 2.2.1

How reproducible:
Every time.

Steps to Reproduce:
1. Click on the edit menu.
2. Click on preferences.

Actual results:
The following error is shown.
```
Error launching preferences: Argument 1 does not allow None as a value

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/preferences.py", line 24, in show_instance
    cls._instance = vmmPreferences()
  File "/usr/share/virt-manager/virtManager/preferences.py", line 55, in __init__
    self.refresh_grabkeys_combination()
  File "/usr/share/virt-manager/virtManager/preferences.py", line 297, in refresh_grabkeys_combination
    self.widget("prefs-keys-grab-sequence").set_text(keystr)
TypeError: Argument 1 does not allow None as a value
```

Expected results:
The preferences dialog is shown.

Additional info:
I don't remember the last time I tried to get to the preferences so I don't have a last working version for you. Also I'm running i3 on Debian bullseye/sid in case it matters. I can easily provide my i3 config if my keybindings are suspect.

Comment 1 Cole Robinson 2020-04-13 20:49:28 UTC
Thanks for the report. I'm not sure what about your config was causing this error
but with this commit it will no longer throw an error

commit f6eee380a25f8ae9620cba2fead73f54888c68b3
Author: Cole Robinson <crobinso>
Date:   Mon Apr 13 12:44:47 2020 -0400

    preferences: Fix dialog when invalid keygrab is set
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1810106