Bug 1810358

Summary:	pid file of rsync is re-enabled when updating overcloud stack
Product:	Red Hat OpenStack	Reporter:	Takashi Kajinami <tkajinam>
Component:	openstack-tripleo-heat-templates	Assignee:	Christian Schwede (cschwede) <cschwede>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Joe H. Rahme <jhakimra>
Severity:	high	Docs Contact:
Priority:	medium
Version:	13.0 (Queens)	CC:	cschwede, knoha, lmarsh, mburns, nalmond, ramishra
Target Milestone:	zstream	Keywords:	Triaged, ZStream
Target Release:	13.0 (Queens)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-11 20:29:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Takashi Kajinami 2020-03-05 04:15:33 UTC

Description of problem:

Since the following patch was introduced in stable/queens and RHOSP13,
we expect "pid file" is removed from rsyncd.conf to avoid the issue
caused by pid file remaining in the container because of some reasons
like force shutdown.

 https://review.opendev.org/#/c/577126/

This works as expected in initial deployment.
However, the swift_rsync_fix is not invoked when updating overcloud stack,
and this causes "pid file" remains in rsyncd.conf after puppet reapplies
the configuration.

Version-Release number of selected component (if applicable):
Confirmed the problem is reproduced in z10

How reproducible:
Always

Steps to Reproduce:
1. Deploy overcloud
2. see that "pid file" is not included in /var/lib/config-data/puppet-generated/swift/etc/rsyncd.conf in controller nodes
3. Update overcloud by "openstack overcloud deploy" with the exactly the same template
4. see /var/lib/config-data/puppet-generated/swift/etc/rsyncd.conf in controller nodes

Actual results:
"pid file" is added to rsyncd.conf

Expected results:
"pid file" does not exist in rsyncd.conf

Additional info:

Comment 9 Lon Hohberger 2023-07-11 20:29:56 UTC

This was resolved in a later release. As OSP13 is now retired as of June 27, 2023, no further action will be taken on this issue.