Bug 1810384

Summary: Got failure when team.ports are not sorted by name
Product: Red Hat Enterprise Linux 8 Reporter: Mingyu Shi <mshi>
Component: nmstateAssignee: Fernando F. Mancera <ferferna>
Status: CLOSED ERRATA QA Contact: Mingyu Shi <mshi>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.2CC: ferferna, fge, jiji, jishi, network-qe, till
Target Milestone: rc   
Target Release: 8.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nmstate-0.3.2-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 03:08:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
failure logs
none
verified.log none

Description Mingyu Shi 2020-03-05 06:34:39 UTC
Created attachment 1667645 [details]
failure logs

Description of problem:
Got failure when veth and dummy both are in team.ports

Version-Release number of selected component (if applicable):
nmstate-0.2.6-1.el8.noarch
NetworkManager-1.22.8-1.el8.x86_64

How reproducible:
100%

Steps to Reproduce:
# cat team0.yaml 
---
interfaces:
- name: team0
  state: up
  type: team
  team:
    ports:
    - name: vethteam0
    - name: dummy0

1. ip link add vethteam0 type veth peer name vethteam0_ep
nmcli dev set vethteam0 managed yes
2. nmstatectl set team0.yaml
3.

Actual results:
Got failure

Expected results:
No failure

Additional info:
It's ok to create as all-dummy or all-veth, but put them together.

Comment 1 Mingyu Shi 2020-03-05 16:06:21 UTC
Update: it is due to the order of the slave names, nothing to do with veth and slave

ports:
- name: a
- name: b

will be ok, but

ports:
- name: b
- name: a

will get a failure

Comment 2 Gris Ge 2020-03-06 02:24:17 UTC
Upstream issue tracker: https://github.com/nmstate/nmstate/issues/889

Comment 4 Fernando F. Mancera 2020-04-26 22:24:55 UTC
Upstream patch merged: https://github.com/nmstate/nmstate/pull/982

Comment 7 Mingyu Shi 2020-07-10 07:45:18 UTC
Created attachment 1700553 [details]
verified.log

Verified with versions:
nmstate-0.3.3-2.el8.noarch
NetworkManager-1.26.0-0.2.1.el8.x86_64
DISTRO=RHEL-8.3.0-20200709.n.0
Linux hpe-dl380pgen8-02-vm-11.hpe2.lab.eng.bos.redhat.com 4.18.0-223.el8.x86_64 #1 SMP Tue Jul 7 12:56:57 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
openvswitch2.12-2.12.0-12.el8fdp.x86_64
openvswitch-selinux-extra-policy-1.0-19.el8fdp.noarch

Use this yaml:
# cat team0.yaml 
---
interfaces:
- name: team0
  state: up
  type: team
  team:
    ports:
    - name: veth9
    - name: veth8
    - name: veth7
    - name: veth6
    - name: veth5
    - name: dummy0
    - name: veth0
    - name: veth4
    - name: veth3
    - name: veth2
    - name: veth12
    - name: veth11
    - name: veth10
    - name: veth1
- name: dummy0
  state: up
  type: dummy

Comment 10 errata-xmlrpc 2020-11-04 03:08:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4696