Bug 1810555

Summary:	[RFE] Add a check on the existence of a conversion host with the same VM
Product:	Red Hat CloudForms Management Engine	Reporter:	Maayan Hadasi <mguetta>
Component:	V2V	Assignee:	Fabien Dupont <fdupont>
Status:	CLOSED ERRATA	QA Contact:	Nandini Chandra <nachandr>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	medium
Version:	5.11.4	CC:	bthurber, dagur, istein, simaishi, sshveta
Target Milestone:	GA	Keywords:	FutureFeature, ZStream
Target Release:	5.11.5	Flags:	pm-rhel: cfme-5.11.z+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.5.0	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-05 13:43:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	V2V	Target Upstream Version:
Embargoed:

Description Maayan Hadasi 2020-03-05 13:46:01 UTC

Description of problem:
Adding a conversion host by REST API while there is an existing conversion host with the same VM, will cause an unexpected behavior  


Version-Release number of selected component (if applicable):
CFME 5.11.4.1


How reproducible:
100%


Actual results:
The existing conversion host is overridden by the 2nd process.
In UI, the conversion host configuration is failed, although there are no errors in conversion host log and it can be used for migration

In evm.log - there are some errors as: 
[----] E, [2020-03-05T04:49:37.896134 #40326:2af8039725b8] ERROR -- : MIQ(MiqQueue#deliver) Message id: [41519], Error: [Validation failed: ConversionHost: Resource has already been taken]


Expected results:
Adding a check on the existence of a conversion host with the same VM

Comment 2 Fabien Dupont 2020-03-06 07:43:05 UTC

https://github.com/ManageIQ/manageiq-api/pull/769

Comment 3 Fabien Dupont 2020-03-10 17:49:00 UTC

https://github.com/ManageIQ/manageiq/pull/19945

Comment 4 CFME Bot 2020-04-13 14:15:17 UTC

New commit detected on ManageIQ/manageiq/jansa:

https://github.com/ManageIQ/manageiq/commit/1800825b03d8ff75a15e391cd4d6cada037d74ef
commit 1800825b03d8ff75a15e391cd4d6cada037d74ef
Author:     Brandon Dunne <bdunne>
AuthorDate: Tue Mar 10 17:42:23 2020 +0000
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Mar 10 17:42:23 2020 +0000

    Merge pull request #19945 from fdupont-redhat/v2V_bz_1810555

    [V2V] ConversionHost - Validate resource is not already a conversion host

    (cherry picked from commit 6826efd6fb173517876caf05e2f924b46531413d)

    https://bugzilla.redhat.com/show_bug.cgi?id=1810555

 app/models/conversion_host/configurations.rb | 2 +
 spec/models/conversion_host/configurations_spec.rb | 5 +
 2 files changed, 7 insertions(+)

Comment 8 Nandini Chandra 2020-04-24 22:22:03 UTC

Thanks Fabien for the clarification.

Verified in 5.11.5.1

Comment 11 errata-xmlrpc 2020-05-05 13:43:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2020