Bug 1810756

Summary: Hybrid overlay annotations missing from nodes
Product: OpenShift Container Platform Reporter: Sebastian Soto <ssoto>
Component: NetworkingAssignee: Phil Cameron <pcameron>
Networking sub component: ovn-kubernetes QA Contact: Anurag saxena <anusaxen>
Status: CLOSED ERRATA Docs Contact:
Severity: unspecified    
Priority: unspecified CC: aravindh, dcbw, pcameron
Version: 4.4   
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-13 17:18:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sebastian Soto 2020-03-05 20:38:59 UTC
Description of problem:
After applying the hybrid overlay patch to an OVN cluster, the k8s.ovn.org/hybrid-overlay-node-subnet and k8s.ovn.org/hybrid-overlay-distributed-router-gateway-mac annotations are missing.

This is a regression, and is required for Windows.

Version-Release number of selected component (if applicable):
4.5.0-0.ci-2020-03-05-134327

How reproducible:

Steps to Reproduce:
1.Apply the hybrid overlay patch to an ovn cluster
oc patch network.operator cluster --type=merge -p '{"spec":{"defaultNetwork":{"ovnKubernetesConfig":{"hybridOverlayConfig":{"hybridClusterNetwork":[{"cidr":"10.132.0.0/14","hostPrefix":23}]}}}}}'
2. Check the node annotations: 
oc get no -o jsonpath='{.items[*].metadata.annotations}'

Actual results:
Annotations are missing

Expected results:
The k8s.ovn.org/hybrid-overlay-node-subnet and k8s.ovn.org/hybrid-overlay-distributed-router-gateway-mac annotations are present on each node

Additional info:

Comment 1 Dan Williams 2020-03-05 20:53:22 UTC

*** This bug has been marked as a duplicate of bug 1810608 ***

Comment 2 Dan Williams 2020-03-05 21:04:05 UTC
Can you grab ovnkube node container logs from an affected node?

ovnkube master container logs would also be useful.

Comment 3 Aravindh Puthiyaparambil 2020-03-05 21:09:08 UTC
Handed over my cluster to @dcbw for debugging.

Comment 4 Dan Williams 2020-03-05 22:28:19 UTC
https://github.com/openshift/cluster-network-operator/pull/500 appears to have quoting issues, Phil/Jacob will fix. This is preventing the ovnkube master from enabling hybrid overlay.

Comment 5 Dan Williams 2020-03-05 22:49:33 UTC
And https://github.com/openshift/cluster-network-operator/pull/515 for master/4.5

Comment 6 Dan Williams 2020-03-05 22:49:56 UTC
https://github.com/openshift/cluster-network-operator/pull/514 for 4.4

Comment 11 errata-xmlrpc 2020-07-13 17:18:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409