Bug 1811265

Summary:	Review Request: rust-xkbcommon - keyboard handling library from crates.rs
Product:	[Fedora] Fedora	Reporter:	Nikhil Jha <hi>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review, pbrobinson
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-26 00:47:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	177841, 1817424, 1811266

Description Nikhil Jha 2020-03-07 02:56:28 UTC

Spec URL: https://gitlab.com/fedora-mobile/rust-xkbcommon/-/raw/master/rust-xkbcommon.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora-rawhide-x86_64/01278753-rust-xkbcommon/rust-xkbcommon-0.4.0-1.fc33.src.rpm
Description: The xkbcommon keyboard handling library from crates.rs
Fedora Account System Username: njha

This is a dependency of squeekboard (a wayland touchscreen keyboard- meant for phones), which I have submitted separately.

Comment 1 Nikhil Jha 2020-03-07 02:58:43 UTC

Request for squeekboard: https://bugzilla.redhat.com/show_bug.cgi?id=1811266
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42218938

Comment 2 Robert-André Mauchin 🐧 2020-03-24 17:29:00 UTC

 - You must install the LICENSE file with %license in %files

%files          devel
%doc README.md
%license LICENSE
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 3 Nikhil Jha 2020-03-24 18:39:00 UTC

Added the LICENSE file and rebuilt in COPR: https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1316365/

Thanks!

Comment 4 Robert-André Mauchin 🐧 2020-03-24 19:12:10 UTC

Package approved.

Comment 5 Gwyn Ciesla 2020-03-24 20:30:39 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-xkbcommon