Bug 1811306

Summary: python-notebook fails to build with Python 3.9: encoding parameter of json.loads() has been removed
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-notebookAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, mhroncok, mplch, python-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-16 18:47:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-03-07 11:52:37 UTC
python-notebook fails to build with Python 3.9.0a4.

Traceback (most recent call last):
  File "/builddir/build/BUILD/notebook-6.0.2/notebook/tests/test_gateway.py", line 178, in test_gateway_get_kernelspecs
    content = json.loads(response.content.decode('utf-8'), encoding='utf-8')
  File "/usr/lib64/python3.9/json/__init__.py", line 359, in loads
    return cls(**kw).decode(s)
TypeError: __init__() got an unexpected keyword argument 'encoding'


See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The encoding parameter of json.loads() has been removed. As of Python 3.1, it was deprecated and ignored; using it has emitted a DeprecationWarning since Python 3.8."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01296959-python-notebook/

For all our attempts to build python-notebook with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-notebook/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 2 Miro Hrončok 2020-03-16 18:47:57 UTC
Fix backported, pushed to dist git.