Bug 1811936
| Summary: | Package review: intel-pmwatch - Intel Optane DCPMM monitoring and reporting | ||
|---|---|---|---|
| Product: | [Community] RDO | Reporter: | piotrx.rabiega |
| Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
| Status: | NEW --- | QA Contact: | Matthias Runge <mrunge> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | mrunge |
| Target Milestone: | --- | Flags: | mrunge:
rdo-review+
|
| Target Release: | trunk | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1611781 | ||
|
Description
piotrx.rabiega
2020-03-10 09:27:20 UTC
Here is output from licensecheck: licensecheck -r . ./autogen.sh: *No copyright* UNKNOWN ./build_pmwatch.sh: *No copyright* UNKNOWN ./package_pmwatch.sh: MIT/X11 (BSD like) ./prepare_pmwatch_release.sh: MIT/X11 (BSD like) ./scripts/esxi/pmw_vars.sh: MIT/X11 (BSD like) ./scripts/pmw_vars.sh: MIT/X11 (BSD like) ./src/inc/pmw_api.h: MIT/X11 (BSD like) ./src/inc/pmw_collect.h: MIT/X11 (BSD like) ./src/inc/pmw_comm.h: MIT/X11 (BSD like) ./src/inc/pmw_struct.h: MIT/X11 (BSD like) ./src/inc/pmw_utils.h: MIT/X11 (BSD like) ./src/inc/pmw_version.h: MIT/X11 (BSD like) ./src/pmw_api.c: MIT/X11 (BSD like) ./src/pmw_collect.c: MIT/X11 (BSD like) ./src/pmw_comm.c: MIT/X11 (BSD like) ./src/pmw_utils.c: MIT/X11 (BSD like) ./src/pmwatch.c: MIT/X11 (BSD like) In order to get a package review, please link to a SRPM and also to the spec file. Otherwise it's impossible for anyone to do a review. Spec URL: https://raw.githubusercontent.com/prabiegx/intel-pmwatch/review/intel-pmwatch.spec SRPM URL: https://github.com/prabiegx/intel-pmwatch/raw/review/intel-pmwatch-3.2.0-1.el7.src.rpm SPEC: https://raw.githubusercontent.com/prabiegx/intel-pmwatch/review/intel-pmwatch.spec SRPM: https://github.com/prabiegx/intel-pmwatch/raw/review/intel-pmwatch-3.2.0-1.el7.src.rpm could you please update and link to the new SRPM file? INFO: Processing bugzilla bug: 1811936 INFO: Getting .spec and .srpm Urls from : 1811936 INFO: --> SRPM url: https://github.com/prabiegx/intel-pmwatch/raw/review/intel-pmwatch-3.2.0-1.el7.src.rpm INFO: --> Spec url: https://raw.githubusercontent.com/prabiegx/intel-pmwatch/review/intel-pmwatch.spec INFO: Using review directory: /home/mrunge/review/1811936-intel-pmwatch INFO: Downloading .spec and .srpm files ERROR: 'Error 404 downloading https://github.com/prabiegx/intel-pmwatch/raw/review/intel-pmwatch-3.2.0-1.el7.src.rpm' (logs in /home/mrunge/.cache/fedora-review.log) SPEC: https://raw.githubusercontent.com/prabiegx/intel-pmwatch/6fd7b42146f6c0019b3034f2b2b3bead4bc86173/intel-pmwatch.spec SRPM: https://github.com/prabiegx/intel-pmwatch/raw/6fd7b42146f6c0019b3034f2b2b3bead4bc86173/intel-pmwatch-3.2.1-1.el7.src.rpm checking for cc++... no
checking for cl.exe... no
checking for FCC... no
checking for KCC... no
checking for RCC... no
checking for xlC_r... no
checking for xlC... no
checking whether the C++ compiler works... no
configure: error: in `/builddir/build/BUILD/intel-pmwatch-3.2.1':
configure: error: C++ compiler cannot create executables
See `config.log' for more details
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.qCdmdv (%prep)
Bad exit status from /var/tmp/rpm-tmp.qCdmdv (%prep)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace
result = func(*args, **kw)
File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 776, in do_with_status
raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode)
mockbuild.exception.Error: Command failed:
# /usr/bin/systemd-nspawn -q -M 0a177fb2ed104e7b9846e1efff3584d1 -D /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock --bind=/tmp/mock-resolv.5xrwdw1w:/etc/resolv.conf --bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ --setenv=LANG=C.UTF-8 bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/intel-pmwatch.spec
There is still a missing BuildRequires: gcc-c++
SPEC: https://raw.githubusercontent.com/prabiegx/intel-pmwatch/aae5247aedaeb57b0e37662b1283327d52e9d275/intel-pmwatch.spec SRPM: https://github.com/prabiegx/intel-pmwatch/raw/aae5247aedaeb57b0e37662b1283327d52e9d275/intel-pmwatch-3.2.1-1.el7.src.rpm Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - ldconfig not called in %post and %postun for Fedora 28 and later. Note: /sbin/ldconfig called in intel-pmwatch See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 14 files have unknown license. Detailed output of licensecheck in /home/mrunge/review/1811936-intel-pmwatch/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: intel-pmwatch-devel. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in intel- pmwatch-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: intel-pmwatch-3.2.1-1.fc33.x86_64.rpm intel-pmwatch-devel-3.2.1-1.fc33.x86_64.rpm intel-pmwatch-debuginfo-3.2.1-1.fc33.x86_64.rpm intel-pmwatch-debugsource-3.2.1-1.fc33.x86_64.rpm intel-pmwatch-3.2.1-1.fc33.src.rpm intel-pmwatch.x86_64: W: no-manual-page-for-binary pmwatch intel-pmwatch.x86_64: W: no-manual-page-for-binary pmwatch-stop intel-pmwatch-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: intel-pmwatch-debuginfo-3.2.1-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- intel-pmwatch-debuginfo.x86_64: W: invalid-url URL: https://github.com/intel/intel-pmwatch <urlopen error [Errno -2] Name or service not known> intel-pmwatch-debugsource.x86_64: W: invalid-url URL: https://github.com/intel/intel-pmwatch <urlopen error [Errno -2] Name or service not known> intel-pmwatch-devel.x86_64: W: invalid-url URL: https://github.com/intel/intel-pmwatch <urlopen error [Errno -2] Name or service not known> intel-pmwatch-devel.x86_64: W: no-documentation intel-pmwatch.x86_64: W: invalid-url URL: https://github.com/intel/intel-pmwatch <urlopen error [Errno -2] Name or service not known> intel-pmwatch.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpmwapi.so.0.0.0 /lib64/libipmctl.so.3 intel-pmwatch.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libpmwapi.so.0.0.0 /lib64/libpthread.so.0 intel-pmwatch.x86_64: W: no-manual-page-for-binary pmwatch intel-pmwatch.x86_64: W: no-manual-page-for-binary pmwatch-stop 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Source checksums ---------------- https://github.com/intel/intel-pmwatch/archive/v3.2.1.tar.gz#/intel-pmwatch-3.2.1.tar.gz : CHECKSUM(SHA256) this package : 7fa41cdaa32ad8d0defe51a9e7cf8b62499e98a84298170db69e30c75a63538b CHECKSUM(SHA256) upstream package : 7fa41cdaa32ad8d0defe51a9e7cf8b62499e98a84298170db69e30c75a63538b Requires -------- intel-pmwatch (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/bash libc.so.6()(64bit) libipmctl.so.3()(64bit) libkmod.so.2()(64bit) libpmwcollect.so.0()(64bit) libpthread.so.0()(64bit) libudev.so.1()(64bit) libuuid.so.1()(64bit) rtld(GNU_HASH) intel-pmwatch-devel (rpmlib, GLIBC filtered): intel-pmwatch libpmwapi.so.0()(64bit) libpmwcollect.so.0()(64bit) intel-pmwatch-debuginfo (rpmlib, GLIBC filtered): intel-pmwatch-debugsource (rpmlib, GLIBC filtered): Provides -------- intel-pmwatch: intel-pmwatch intel-pmwatch(x86-64) libpmwapi.so.0()(64bit) libpmwcollect.so.0()(64bit) intel-pmwatch-devel: intel-pmwatch-devel intel-pmwatch-devel(x86-64) intel-pmwatch-static intel-pmwatch-debuginfo: debuginfo(build-id) intel-pmwatch-debuginfo intel-pmwatch-debuginfo(x86-64) intel-pmwatch-debugsource: intel-pmwatch-debugsource intel-pmwatch-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1811936 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: PHP, Python, fonts, Ocaml, R, SugarActivity, Java, Haskell, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Package approved |